diff options
author | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-02-11 05:18:59 +0000 |
---|---|---|
committer | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-02-11 05:18:59 +0000 |
commit | d56aef7f55220a0654655c691e5adcc1a1dd0cd8 (patch) | |
tree | 733dccd319ea18293fb3610c1bed6ee7a3ff66a8 /chrome_frame | |
parent | f40061ba0477aff1326f71d663748d6359c48a19 (diff) | |
download | chromium_src-d56aef7f55220a0654655c691e5adcc1a1dd0cd8.zip chromium_src-d56aef7f55220a0654655c691e5adcc1a1dd0cd8.tar.gz chromium_src-d56aef7f55220a0654655c691e5adcc1a1dd0cd8.tar.bz2 |
Revert 74561 for breaking the ChromeOS build
Introduce OffTheRecordProfileIOData and ProfileImplIOData.
They both inherit from ProfileIOData. The former is for the off the record (incognito) profile. The latter is for the normal ProfileImpl profile.
All of the IO related Profile objects are now initialized at the same time, in the subtype implementations of ProfileIOData::LazyInitializeInternal().
I also took this opportunity to clean URLRequestContext up so it is a class and keeps its member variables private. This required touching a fair number of files.
TODO: Remove lots of the refcounting of member variables, since they can now be owned by ProfileIOData.
BUG=67237
TEST=none
Review URL: http://codereview.chromium.org/6286133
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/6489020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74564 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome_frame')
-rw-r--r-- | chrome_frame/metrics_service.cc | 42 |
1 files changed, 21 insertions, 21 deletions
diff --git a/chrome_frame/metrics_service.cc b/chrome_frame/metrics_service.cc index a1242cb..706b591 100644 --- a/chrome_frame/metrics_service.cc +++ b/chrome_frame/metrics_service.cc @@ -142,10 +142,10 @@ class ChromeFrameUploadRequestContext : public net::URLRequestContext { ~ChromeFrameUploadRequestContext() { DVLOG(1) << __FUNCTION__; - delete http_transaction_factory(); - delete http_auth_handler_factory(); - delete cert_verifier(); - delete host_resolver(); + delete http_transaction_factory_; + delete http_auth_handler_factory_; + delete cert_verifier_; + delete host_resolver_; } void Initialize() { @@ -153,19 +153,19 @@ class ChromeFrameUploadRequestContext : public net::URLRequestContext { user_agent_ = http_utils::AddChromeFrameToUserAgentValue( user_agent_); - set_host_resolver( + host_resolver_ = net::CreateSystemHostResolver(net::HostResolver::kDefaultParallelism, - NULL, NULL)); - set_cert_verifier(new net::CertVerifier); + NULL, NULL); + cert_verifier_ = new net::CertVerifier; net::ProxyConfigService* proxy_config_service = net::ProxyService::CreateSystemProxyConfigService(NULL, NULL); DCHECK(proxy_config_service); - set_proxy_service(net::ProxyService::CreateUsingSystemProxyResolver( - proxy_config_service, 0, NULL)); - DCHECK(proxy_service()); + proxy_service_ = net::ProxyService::CreateUsingSystemProxyResolver( + proxy_config_service, 0, NULL); + DCHECK(proxy_service_); - set_ssl_config_service(new net::SSLConfigServiceDefaults); + ssl_config_service_ = new net::SSLConfigServiceDefaults; url_security_manager_.reset( net::URLSecurityManager::Create(NULL, NULL)); @@ -174,23 +174,23 @@ class ChromeFrameUploadRequestContext : public net::URLRequestContext { std::vector<std::string> supported_schemes; base::SplitString(csv_auth_schemes, ',', &supported_schemes); - set_http_auth_handler_factory(net::HttpAuthHandlerRegistryFactory::Create( - supported_schemes, url_security_manager_.get(), host_resolver(), - std::string(), false, false)); + http_auth_handler_factory_ = net::HttpAuthHandlerRegistryFactory::Create( + supported_schemes, url_security_manager_.get(), host_resolver_, + std::string(), false, false); net::HttpNetworkSession::Params session_params; - session_params.host_resolver = host_resolver(); - session_params.cert_verifier = cert_verifier(); - session_params.proxy_service = proxy_service(); + session_params.host_resolver = host_resolver_; + session_params.cert_verifier = cert_verifier_; + session_params.proxy_service = proxy_service_; session_params.http_auth_handler_factory = - http_auth_handler_factory(); - session_params.ssl_config_service = ssl_config_service(); + http_auth_handler_factory_; + session_params.ssl_config_service = ssl_config_service_; scoped_refptr<net::HttpNetworkSession> network_session = new net::HttpNetworkSession(session_params); - set_http_transaction_factory(new net::HttpCache( + http_transaction_factory_ = new net::HttpCache( network_session, - net::HttpCache::DefaultBackend::InMemory(0))); + net::HttpCache::DefaultBackend::InMemory(0)); } virtual const std::string& GetUserAgent(const GURL& url) const { |