diff options
author | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-06 01:46:59 +0000 |
---|---|---|
committer | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-06 01:46:59 +0000 |
commit | ed578097fa1a348906fdd74ea32bf140c8f75071 (patch) | |
tree | 46decb9874a9573f64a3a86893a7dec063fa97fb /chrome_frame | |
parent | abb4e8e1ecd63ce8d80e7ab514b748c2cbf201b8 (diff) | |
download | chromium_src-ed578097fa1a348906fdd74ea32bf140c8f75071.zip chromium_src-ed578097fa1a348906fdd74ea32bf140c8f75071.tar.gz chromium_src-ed578097fa1a348906fdd74ea32bf140c8f75071.tar.bz2 |
Remove GetSwitchValue() from chrome/* where easy.
Review URL: http://codereview.chromium.org/3057033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55176 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome_frame')
-rw-r--r-- | chrome_frame/test/net/process_singleton_subclass.cc | 4 | ||||
-rw-r--r-- | chrome_frame/test/reliability/page_load_test.cc | 20 | ||||
-rw-r--r-- | chrome_frame/test/reliability/run_all_unittests.cc | 4 |
3 files changed, 16 insertions, 12 deletions
diff --git a/chrome_frame/test/net/process_singleton_subclass.cc b/chrome_frame/test/net/process_singleton_subclass.cc index 2046e0b..d1f473b 100644 --- a/chrome_frame/test/net/process_singleton_subclass.cc +++ b/chrome_frame/test/net/process_singleton_subclass.cc @@ -100,8 +100,8 @@ LRESULT ProcessSingletonSubclass::OnCopyData(HWND hwnd, HWND from_hwnd, std::wstring cmd_line(begin, static_cast<size_t>(end - begin)); CommandLine parsed_command_line = CommandLine::FromString(cmd_line); - std::string channel_id(WideToASCII(parsed_command_line.GetSwitchValue( - switches::kAutomationClientChannelID))); + std::string channel_id = parsed_command_line.GetSwitchValueASCII( + switches::kAutomationClientChannelID); EXPECT_FALSE(channel_id.empty()); delegate_->OnConnectAutomationProviderToChannel(channel_id); diff --git a/chrome_frame/test/reliability/page_load_test.cc b/chrome_frame/test/reliability/page_load_test.cc index 2e44e04..39a40dc 100644 --- a/chrome_frame/test/reliability/page_load_test.cc +++ b/chrome_frame/test/reliability/page_load_test.cc @@ -561,15 +561,17 @@ void SetPageRange(const CommandLine& parsed_command_line) { if (parsed_command_line.HasSwitch(kStartIndexSwitch)) { ASSERT_TRUE( - base::StringToInt(WideToUTF16(parsed_command_line.GetSwitchValue( - kStartIndexSwitch)), &g_start_index)); + base::StringToInt(parsed_command_line.GetSwitchValue( + kStartIndexSwitch), + &g_start_index)); ASSERT_GT(g_start_index, 0); } if (parsed_command_line.HasSwitch(kEndIndexSwitch)) { ASSERT_TRUE( - base::StringToInt(WideToUTF16(parsed_command_line.GetSwitchValue( - kEndIndexSwitch)), &g_end_index)); + base::StringToInt(parsed_command_line.GetSwitchValue( + kEndIndexSwitch), + &g_end_index)); ASSERT_GT(g_end_index, 0); } @@ -580,8 +582,9 @@ void SetPageRange(const CommandLine& parsed_command_line) { if (parsed_command_line.HasSwitch(kIterationSwitch)) { ASSERT_TRUE( - base::StringToInt(WideToUTF16(parsed_command_line.GetSwitchValue( - kIterationSwitch)), &g_iterations)); + base::StringToInt(parsed_command_line.GetSwitchValue( + kIterationSwitch), + &g_iterations)); ASSERT_GT(g_iterations, 0); } @@ -596,8 +599,9 @@ void SetPageRange(const CommandLine& parsed_command_line) { if (parsed_command_line.HasSwitch(kTimeoutSwitch)) { ASSERT_TRUE( - base::StringToInt(WideToUTF16(parsed_command_line.GetSwitchValue( - kTimeoutSwitch)), &g_timeout_ms)); + base::StringToInt(parsed_command_line.GetSwitchValue( + kTimeoutSwitch), + &g_timeout_ms)); ASSERT_GT(g_timeout_ms, 0); } diff --git a/chrome_frame/test/reliability/run_all_unittests.cc b/chrome_frame/test/reliability/run_all_unittests.cc index 3b2604d..26510e5 100644 --- a/chrome_frame/test/reliability/run_all_unittests.cc +++ b/chrome_frame/test/reliability/run_all_unittests.cc @@ -10,7 +10,7 @@ #include "chrome_frame/test_utils.h" #include "chrome_frame/utils.h" -const wchar_t kRegisterDllFlag[] = L"register"; +static const char kRegisterDllFlag[] = "register"; int main(int argc, char **argv) { @@ -29,7 +29,7 @@ int main(int argc, char **argv) { int result = -1; if (cmd_line->HasSwitch(kRegisterDllFlag)) { - std::wstring dll_path = cmd_line->GetSwitchValue(kRegisterDllFlag); + std::wstring dll_path = cmd_line->GetSwitchValueNative(kRegisterDllFlag); // Run() must be called within the scope of the ScopedChromeFrameRegistrar // to ensure that the correct DLL remains registered during the tests. |