diff options
| author | etienneb@chromium.org <etienneb@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-08-21 06:47:33 +0000 |
|---|---|---|
| committer | etienneb@chromium.org <etienneb@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-08-21 06:47:33 +0000 |
| commit | 6504c08e583886c60a2322b29c589c3ca6473215 (patch) | |
| tree | 4e2edce3b883adf459c5de2ae772d6ef4d93cf75 /chrome_frame | |
| parent | aaa1c6ee0977f25a81c6a0cc843b5eb9fd416d58 (diff) | |
| download | chromium_src-6504c08e583886c60a2322b29c589c3ca6473215.zip chromium_src-6504c08e583886c60a2322b29c589c3ca6473215.tar.gz chromium_src-6504c08e583886c60a2322b29c589c3ca6473215.tar.bz2 | |
Add missing DCHECK to validate HR.
This issue was found by a linter.
The value of 'hr' is ignored. Probably a nice idea to validate the CreateInstance success.
R=amit@chromium.org,tommi@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/21948002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218662 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome_frame')
| -rw-r--r-- | chrome_frame/urlmon_bind_status_callback.cc | 2 | ||||
| -rw-r--r-- | chrome_frame/urlmon_moniker.cc | 1 |
2 files changed, 3 insertions, 0 deletions
diff --git a/chrome_frame/urlmon_bind_status_callback.cc b/chrome_frame/urlmon_bind_status_callback.cc index 006e20e..056ea5e 100644 --- a/chrome_frame/urlmon_bind_status_callback.cc +++ b/chrome_frame/urlmon_bind_status_callback.cc @@ -320,6 +320,8 @@ STDMETHODIMP BSCBStorageBind::OnStopBinding(HRESULT hresult, LPCWSTR error) { ExceptionBarrier barrier; HRESULT hr = MayPlayBack(BSCF_LASTDATANOTIFICATION); + if (FAILED(hr)) + return hr; hr = CallbackImpl::OnStopBinding(hresult, error); ReleaseBind(); return hr; diff --git a/chrome_frame/urlmon_moniker.cc b/chrome_frame/urlmon_moniker.cc index d2d5b11..432dd92 100644 --- a/chrome_frame/urlmon_moniker.cc +++ b/chrome_frame/urlmon_moniker.cc @@ -243,6 +243,7 @@ HRESULT MonikerPatch::BindToStorage(IMoniker_BindToStorage_Fn original, CComObject<BSCBStorageBind>* callback = NULL; if (ShouldWrapCallback(me, iid, bind_ctx)) { hr = CComObject<BSCBStorageBind>::CreateInstance(&callback); + DCHECK(SUCCEEDED(hr)); auto_release_callback = callback; DCHECK_EQ(callback->m_dwRef, 1); hr = callback->Initialize(me, bind_ctx); |