diff options
| author | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-23 03:01:47 +0000 |
|---|---|---|
| committer | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-23 03:01:47 +0000 |
| commit | 2ea65b94fade599f63a1b8599b5977a0a57680a2 (patch) | |
| tree | 1c7f804c8a15de702d5d7d5d3d79aebe604cf09e /chrome_frame | |
| parent | 21abcc74837a6cb9537a8026a1b12efc9da402f0 (diff) | |
| download | chromium_src-2ea65b94fade599f63a1b8599b5977a0a57680a2.zip chromium_src-2ea65b94fade599f63a1b8599b5977a0a57680a2.tar.gz chromium_src-2ea65b94fade599f63a1b8599b5977a0a57680a2.tar.bz2 | |
Revert 29861 since this fail on the interactive
linux dbg bot, for some weird reason...
Page actions that don't specify an icon (ie.
have a spelling error in the manifest, such as
icon instead of icons/default_icon) caused a
crash when they try to display their icon.
We now check when the extension tries to enable
the page action whether there are any icons to
display. If not, we don't proceed and log an
error to the console.
TBR=nsylvain
BUG=25562
TEST=Covered by browser test.
Review URL: http://codereview.chromium.org/316018
TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/327007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29867 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome_frame')
0 files changed, 0 insertions, 0 deletions