diff options
| author | robertshield@chromium.org <robertshield@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-28 18:48:03 +0000 |
|---|---|---|
| committer | robertshield@chromium.org <robertshield@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-28 18:48:03 +0000 |
| commit | 7eedbdcfb1485d6f20f50151ad13979a719be88f (patch) | |
| tree | 47cd9a679e6285fa6eab982850fa125a56cf382d /chrome_frame | |
| parent | 18cef85adbb63aa6217db6939ef176741eb43154 (diff) | |
| download | chromium_src-7eedbdcfb1485d6f20f50151ad13979a719be88f.zip chromium_src-7eedbdcfb1485d6f20f50151ad13979a719be88f.tar.gz chromium_src-7eedbdcfb1485d6f20f50151ad13979a719be88f.tar.bz2 | |
Remove a DCHECK that happens on every exit of IE. We appear to be leaking automation proxies, which I maintain is a bad thing.
BUG=Start IE with debug CF installed, navigate to a chrome frame page, exit IE, see the DCHECK.
Review URL: http://codereview.chromium.org/342018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30366 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome_frame')
| -rw-r--r-- | chrome_frame/chrome_frame_automation.cc | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/chrome_frame/chrome_frame_automation.cc b/chrome_frame/chrome_frame_automation.cc index 5286f773..27461d3 100644 --- a/chrome_frame/chrome_frame_automation.cc +++ b/chrome_frame/chrome_frame_automation.cc @@ -164,7 +164,12 @@ ProxyFactory::ProxyFactory() } ProxyFactory::~ProxyFactory() { - DCHECK_EQ(proxies_.container().size(), 0); + for (size_t i = 0; i < proxies_.container().size(); ++i) { + if (WAIT_OBJECT_0 != + WaitForSingleObject(proxies_[i]->thread->thread_handle(), 0)) + // TODO(stoyan): Don't leak proxies on exit. + DLOG(ERROR) << "Proxies leaked on exit."; + } } void* ProxyFactory::GetAutomationServer(int launch_timeout, |