diff options
| author | nick@chromium.org <nick@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-22 23:35:11 +0000 |
|---|---|---|
| committer | nick@chromium.org <nick@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-22 23:35:11 +0000 |
| commit | e4456ae44f4f869dba417c0271594a39ad45779e (patch) | |
| tree | 6c4b12aa5978c5d1628d5b8d9bc4a5b9366e4395 /chrome_frame | |
| parent | 5f0a94bd38f533cdd04e938a31f43d880eed71bd (diff) | |
| download | chromium_src-e4456ae44f4f869dba417c0271594a39ad45779e.zip chromium_src-e4456ae44f4f869dba417c0271594a39ad45779e.tar.gz chromium_src-e4456ae44f4f869dba417c0271594a39ad45779e.tar.bz2 | |
Fix a c_str() use-after-free bug in the chrome frame code.
BUG=
TEST=
Review URL: http://codereview.chromium.org/3421029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60233 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome_frame')
| -rw-r--r-- | chrome_frame/chrome_active_document.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/chrome_frame/chrome_active_document.cc b/chrome_frame/chrome_active_document.cc index 516dd09..78f85f2 100644 --- a/chrome_frame/chrome_active_document.cc +++ b/chrome_frame/chrome_active_document.cc @@ -931,8 +931,8 @@ void ChromeActiveDocument::OnAttachExternalTab(int tab_handle, HRESULT hr = S_OK; if (popup_manager_) { - LPCWSTR popup_wnd_url = UTF8ToWide(params.url.spec()).c_str(); - hr = popup_manager_->EvaluateNewWindow(popup_wnd_url, NULL, url_, + const std::wstring& url_wide = UTF8ToWide(params.url.spec()); + hr = popup_manager_->EvaluateNewWindow(url_wide.c_str(), NULL, url_, NULL, FALSE, flags, 0); } // Allow popup |