diff options
author | hans@chromium.org <hans@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-14 10:36:28 +0000 |
---|---|---|
committer | hans@chromium.org <hans@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-14 10:36:28 +0000 |
commit | 515f2492fbc0a023eb089e91e349106da325de5e (patch) | |
tree | d606fd354fe6c4695fe2f635e62774fe582e8232 /chrome_frame | |
parent | a834a1abc0a318a563d9a0eb3adec0df2947a982 (diff) | |
download | chromium_src-515f2492fbc0a023eb089e91e349106da325de5e.zip chromium_src-515f2492fbc0a023eb089e91e349106da325de5e.tar.gz chromium_src-515f2492fbc0a023eb089e91e349106da325de5e.tar.bz2 |
Clang: enable -Wbool-conversions and -Wunused-variables on Linux.
-Wbool-conversion warns about EXPECT_EQ(false, blah), so replace
that with EXPECT_FALSE(blah). Do the same with EXPECT_EQ(true, blah)
for good measure (even though that doesn't generate warnings).
Also remove the one instance of an unused variable.
BUG=69421
TEST=buildbots all compile and all tests pass
Review URL: http://codereview.chromium.org/6300001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71431 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome_frame')
-rw-r--r-- | chrome_frame/test/urlmon_moniker_integration_test.cc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/chrome_frame/test/urlmon_moniker_integration_test.cc b/chrome_frame/test/urlmon_moniker_integration_test.cc index b27b90d..4bf977f 100644 --- a/chrome_frame/test/urlmon_moniker_integration_test.cc +++ b/chrome_frame/test/urlmon_moniker_integration_test.cc @@ -45,8 +45,8 @@ class UrlmonMonikerTest : public testing::Test { }; TEST_F(UrlmonMonikerTest, MonikerPatch) { - EXPECT_EQ(true, MonikerPatch::Initialize()); - EXPECT_EQ(true, MonikerPatch::Initialize()); // Should be ok to call twice. + EXPECT_TRUE(MonikerPatch::Initialize()); + EXPECT_TRUE(MonikerPatch::Initialize()); // Should be ok to call twice. MonikerPatch::Uninitialize(); } @@ -90,7 +90,7 @@ class RunTestServer : public base::Thread { class UrlmonMonikerTestManager { public: explicit UrlmonMonikerTestManager(const wchar_t* test_url) { - EXPECT_EQ(true, MonikerPatch::Initialize()); + EXPECT_TRUE(MonikerPatch::Initialize()); } ~UrlmonMonikerTestManager() { |