diff options
author | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-11-01 19:24:33 +0000 |
---|---|---|
committer | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-11-01 19:24:33 +0000 |
commit | ea1c18e1bf3bbe6d9bb7bb8769142e5f0429293a (patch) | |
tree | 1c0a736b831d15b4e250c41c471791368ecbef6a /chrome_frame | |
parent | 8898ec205da3a100d12ff5ddb64eab993de3cf67 (diff) | |
download | chromium_src-ea1c18e1bf3bbe6d9bb7bb8769142e5f0429293a.zip chromium_src-ea1c18e1bf3bbe6d9bb7bb8769142e5f0429293a.tar.gz chromium_src-ea1c18e1bf3bbe6d9bb7bb8769142e5f0429293a.tar.bz2 |
Revert "Refactor automation messages." due to mysterious problems on mac.
This reverts commit c1c1fed998ee4d839bfe256150e5e59220ebc0ef (r64637).
TBR=nirnimesh@
BUG=51409
TEST=none
Review URL: http://codereview.chromium.org/4194007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64644 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome_frame')
-rw-r--r-- | chrome_frame/cfproxy.h | 6 | ||||
-rw-r--r-- | chrome_frame/cfproxy_proxy.cc | 2 | ||||
-rw-r--r-- | chrome_frame/cfproxy_support.cc | 2 | ||||
-rw-r--r-- | chrome_frame/cfproxy_test.cc | 6 | ||||
-rw-r--r-- | chrome_frame/chrome_active_document.cc | 3 | ||||
-rw-r--r-- | chrome_frame/chrome_active_document.h | 3 | ||||
-rw-r--r-- | chrome_frame/chrome_frame_activex_base.h | 4 | ||||
-rw-r--r-- | chrome_frame/chrome_frame_delegate.h | 4 | ||||
-rw-r--r-- | chrome_frame/chrome_frame_npapi.cc | 2 | ||||
-rw-r--r-- | chrome_frame/chrome_frame_npapi.h | 3 | ||||
-rw-r--r-- | chrome_frame/chrome_frame_plugin.h | 4 | ||||
-rw-r--r-- | chrome_frame/external_tab.cc | 8 | ||||
-rw-r--r-- | chrome_frame/external_tab.h | 10 | ||||
-rw-r--r-- | chrome_frame/external_tab_test.cc | 4 | ||||
-rw-r--r-- | chrome_frame/plugin_url_request.cc | 2 | ||||
-rw-r--r-- | chrome_frame/test/automation_client_mock.h | 2 | ||||
-rw-r--r-- | chrome_frame/test/net/test_automation_provider.cc | 2 | ||||
-rw-r--r-- | chrome_frame/test/reliability/page_load_test.cc | 2 |
18 files changed, 33 insertions, 36 deletions
diff --git a/chrome_frame/cfproxy.h b/chrome_frame/cfproxy.h index c414df7..bfcc998 100644 --- a/chrome_frame/cfproxy.h +++ b/chrome_frame/cfproxy.h @@ -13,8 +13,8 @@ #include "base/lock.h" #include "base/time.h" // for base::TimeDelta #include "base/file_path.h" -#include "chrome/common/automation_constants.h" #include "chrome/common/page_zoom.h" +#include "chrome/test/automation/automation_constants.h" enum FindInPageDirection { BACK = 0, FWD = 1 }; enum FindInPageCase { IGNORE_CASE = 0, CASE_SENSITIVE = 1 }; @@ -34,7 +34,7 @@ namespace IPC { struct NavigationInfo; struct AutomationURLRequest; struct AttachExternalTabParams; - struct MiniContextMenuParams; + struct ContextMenuParams; }; class GURL; @@ -196,7 +196,7 @@ class ChromeProxyDelegate { // Misc. UI. virtual void HandleAccelerator(const MSG& accel_message) = 0; virtual void HandleContextMenu(HANDLE menu_handle, int align_flags, - const IPC::MiniContextMenuParams& params) = 0; + const IPC::ContextMenuParams& params) = 0; virtual void TabbedOut(bool reverse) = 0; // Tab related. diff --git a/chrome_frame/cfproxy_proxy.cc b/chrome_frame/cfproxy_proxy.cc index 15f40ff..e03cb0e 100644 --- a/chrome_frame/cfproxy_proxy.cc +++ b/chrome_frame/cfproxy_proxy.cc @@ -6,7 +6,7 @@ #include "base/tuple.h" #include "ipc/ipc_sync_message.h" -#include "chrome/common/automation_messages.h" +#include "chrome/test/automation/automation_messages.h" CFProxy::CFProxy(CFProxyTraits* api) : ipc_thread_("ipc"), sync_dispatcher_(&tab2delegate_), diff --git a/chrome_frame/cfproxy_support.cc b/chrome_frame/cfproxy_support.cc index 162d039..42e6a28 100644 --- a/chrome_frame/cfproxy_support.cc +++ b/chrome_frame/cfproxy_support.cc @@ -8,8 +8,8 @@ #include "base/atomic_sequence_num.h" #include "base/command_line.h" #include "base/process_util.h" -#include "chrome/common/automation_messages.h" #include "chrome/common/chrome_switches.h" +#include "chrome/test/automation/automation_messages.h" #include "chrome_frame/chrome_launcher_utils.h" #include "chrome_frame/utils.h" // for IsHeadlessMode(); diff --git a/chrome_frame/cfproxy_test.cc b/chrome_frame/cfproxy_test.cc index a8c69f3..28ba8c6 100644 --- a/chrome_frame/cfproxy_test.cc +++ b/chrome_frame/cfproxy_test.cc @@ -5,8 +5,8 @@ #include <string> #include "base/file_path.h" #include "base/waitable_event.h" -#include "chrome/common/automation_messages.h" #include "chrome_frame/cfproxy_private.h" +#include "chrome/test/automation/automation_messages.h" #include "testing/gtest/include/gtest/gtest.h" #include "testing/gmock/include/gmock/gmock.h" #include "testing/gmock_mutant.h" @@ -73,7 +73,7 @@ struct MockChromeProxyDelegate : public ChromeProxyDelegate { // Misc. UI. MOCK_METHOD1(HandleAccelerator, void(const MSG& accel_message)); MOCK_METHOD3(HandleContextMenu, void(HANDLE menu_handle, int align_flags, - const IPC::MiniContextMenuParams& params)); + const IPC::ContextMenuParams& params)); MOCK_METHOD1(TabbedOut, void(bool reverse)); // @@ -472,7 +472,7 @@ TEST(Deserialize, DispatchTabMessage) { EXPECT_TRUE(DispatchTabMessageToDelegate(&delegate, m9)); // Tuple4<int, HANDLE, int, IPC::ContextMenuParams> - IPC::MiniContextMenuParams ctxmenu = { 711, 512, GURL("http://link_src"), + IPC::ContextMenuParams ctxmenu = { 711, 512, GURL("http://link_src"), GURL("http://unfiltered_link_url"), GURL("http://src_url"), GURL("http://page_url"), GURL("http://frame_url") }; AutomationMsg_ForwardContextMenuToExternalHost m10(0, 1, HANDLE(7), 4, diff --git a/chrome_frame/chrome_active_document.cc b/chrome_frame/chrome_active_document.cc index 1f4aa4b..9dfe739 100644 --- a/chrome_frame/chrome_active_document.cc +++ b/chrome_frame/chrome_active_document.cc @@ -31,6 +31,7 @@ #include "base/win/scoped_variant.h" #include "grit/generated_resources.h" #include "chrome/app/chrome_dll_resource.h" +#include "chrome/browser/tab_contents/tab_contents.h" #include "chrome/common/chrome_constants.h" #include "chrome/common/navigation_types.h" #include "chrome/common/page_zoom.h" @@ -969,7 +970,7 @@ bool ChromeActiveDocument::PreProcessContextMenu(HMENU menu) { } bool ChromeActiveDocument::HandleContextMenuCommand(UINT cmd, - const IPC::MiniContextMenuParams& params) { + const IPC::ContextMenuParams& params) { ScopedComPtr<IWebBrowser2> web_browser2; DoQueryService(SID_SWebBrowserApp, m_spClientSite, web_browser2.Receive()); diff --git a/chrome_frame/chrome_active_document.h b/chrome_frame/chrome_active_document.h index 5723e7ff..482a672 100644 --- a/chrome_frame/chrome_active_document.h +++ b/chrome_frame/chrome_active_document.h @@ -344,8 +344,7 @@ END_EXEC_COMMAND_MAP() // Callbacks from ChromeFramePlugin<T> bool PreProcessContextMenu(HMENU menu); - bool HandleContextMenuCommand(UINT cmd, - const IPC::MiniContextMenuParams& params); + bool HandleContextMenuCommand(UINT cmd, const IPC::ContextMenuParams& params); // ChromeFramePlugin overrides. virtual void OnAutomationServerReady(); diff --git a/chrome_frame/chrome_frame_activex_base.h b/chrome_frame/chrome_frame_activex_base.h index 116deb6..def29b8 100644 --- a/chrome_frame/chrome_frame_activex_base.h +++ b/chrome_frame/chrome_frame_activex_base.h @@ -358,7 +358,7 @@ END_MSG_MAP() } bool HandleContextMenuCommand(UINT cmd, - const IPC::MiniContextMenuParams& params) { + const IPC::ContextMenuParams& params) { if (cmd == IDC_ABOUT_CHROME_FRAME) { int tab_handle = automation_client_->tab()->handle(); HostNavigate(GURL("about:version"), GURL(), NEW_WINDOW); @@ -519,7 +519,7 @@ END_MSG_MAP() virtual void OnHandleContextMenu(int tab_handle, HANDLE menu_handle, int align_flags, - const IPC::MiniContextMenuParams& params) { + const IPC::ContextMenuParams& params) { scoped_refptr<BasePlugin> ref(this); ChromeFramePlugin<T>::OnHandleContextMenu(tab_handle, menu_handle, align_flags, params); diff --git a/chrome_frame/chrome_frame_delegate.h b/chrome_frame/chrome_frame_delegate.h index c7890b7..b57cc5b 100644 --- a/chrome_frame/chrome_frame_delegate.h +++ b/chrome_frame/chrome_frame_delegate.h @@ -13,7 +13,7 @@ #include "base/file_path.h" #include "base/lock.h" -#include "chrome/common/automation_messages.h" +#include "chrome/test/automation/automation_messages.h" #include "ipc/ipc_message.h" // A common interface supported by all the browser specific ChromeFrame @@ -108,7 +108,7 @@ class ChromeFrameDelegateImpl : public ChromeFrameDelegate { const std::string& target) {} virtual void OnHandleContextMenu(int tab_handle, HANDLE menu_handle, int align_flags, - const IPC::MiniContextMenuParams& params) {} + const IPC::ContextMenuParams& params) {} virtual void OnRequestStart(int tab_handle, int request_id, const IPC::AutomationURLRequest& request) {} virtual void OnRequestRead(int tab_handle, int request_id, diff --git a/chrome_frame/chrome_frame_npapi.cc b/chrome_frame/chrome_frame_npapi.cc index 5668a5b..9ea07df 100644 --- a/chrome_frame/chrome_frame_npapi.cc +++ b/chrome_frame/chrome_frame_npapi.cc @@ -1476,7 +1476,7 @@ bool ChromeFrameNPAPI::PreProcessContextMenu(HMENU menu) { } bool ChromeFrameNPAPI::HandleContextMenuCommand(UINT cmd, - const IPC::MiniContextMenuParams& params) { + const IPC::ContextMenuParams& params) { if (cmd == IDC_ABOUT_CHROME_FRAME) { // TODO: implement "About Chrome Frame" } diff --git a/chrome_frame/chrome_frame_npapi.h b/chrome_frame/chrome_frame_npapi.h index d606090..5101592 100644 --- a/chrome_frame/chrome_frame_npapi.h +++ b/chrome_frame/chrome_frame_npapi.h @@ -128,8 +128,7 @@ END_MSG_MAP() static void InitializeIdentifiers(); bool PreProcessContextMenu(HMENU menu); - bool HandleContextMenuCommand(UINT cmd, - const IPC::MiniContextMenuParams& params); + bool HandleContextMenuCommand(UINT cmd, const IPC::ContextMenuParams& params); protected: // Handler for accelerator messages passed on from the hosted chrome // instance. diff --git a/chrome_frame/chrome_frame_plugin.h b/chrome_frame/chrome_frame_plugin.h index 58a76a6..9ea6ce9 100644 --- a/chrome_frame/chrome_frame_plugin.h +++ b/chrome_frame/chrome_frame_plugin.h @@ -120,7 +120,7 @@ END_MSG_MAP() virtual void OnHandleContextMenu(int tab_handle, HANDLE menu_handle, int align_flags, - const IPC::MiniContextMenuParams& params) { + const IPC::ContextMenuParams& params) { if (!menu_handle || !automation_client_.get()) { NOTREACHED(); return; @@ -219,7 +219,7 @@ END_MSG_MAP() // Return true if menu command is processed, otherwise the command will be // passed to Chrome for execution. Override in most-derived class if needed. bool HandleContextMenuCommand(UINT cmd, - const IPC::MiniContextMenuParams& params) { + const IPC::ContextMenuParams& params) { return false; } diff --git a/chrome_frame/external_tab.cc b/chrome_frame/external_tab.cc index edc1ad9..4bfeff2 100644 --- a/chrome_frame/external_tab.cc +++ b/chrome_frame/external_tab.cc @@ -7,7 +7,7 @@ #include "base/tracked.h" #include "base/task.h" #include "base/waitable_event.h" -#include "chrome/common/automation_messages.h" +#include "chrome/test/automation/automation_messages.h" #include "chrome_frame/utils.h" DISABLE_RUNNABLE_METHOD_REFCOUNT(ExternalTabProxy); @@ -271,10 +271,8 @@ void ExternalTabProxy::HandleAccelerator(const MSG& accel_message) { &UIDelegate::OnHandleAccelerator, accel_message)); } -void ExternalTabProxy::HandleContextMenu( - HANDLE menu_handle, - int align_flags, - const IPC::MiniContextMenuParams& params) { +void ExternalTabProxy::HandleContextMenu(HANDLE menu_handle, int align_flags, + const IPC::ContextMenuParams& params) { ui_.PostTask(FROM_HERE, NewRunnableMethod(ui_delegate_, &UIDelegate::OnHandleContextMenu, menu_handle, align_flags, params)); } diff --git a/chrome_frame/external_tab.h b/chrome_frame/external_tab.h index 6f890ed..b68a9bf 100644 --- a/chrome_frame/external_tab.h +++ b/chrome_frame/external_tab.h @@ -14,8 +14,8 @@ #include "base/scoped_comptr_win.h" #include "base/scoped_ptr.h" #include "base/time.h" -#include "chrome/common/automation_constants.h" -#include "chrome/common/page_zoom.h" +#include "chrome/common//page_zoom.h" +#include "chrome/test/automation/automation_constants.h" #include "chrome_frame/cfproxy.h" #include "chrome_frame/task_marshaller.h" #include "googleurl/src/gurl.h" @@ -29,7 +29,7 @@ namespace base { namespace IPC { struct NavigationInfo; - struct MiniContextMenuParams; + struct ContextMenuParams; } // This is the delegate/callback interface that has to be implemented @@ -45,7 +45,7 @@ class UIDelegate { virtual void OnMessageFromChromeFrame(const std::string& message, const std::string& origin, const std::string& target) = 0; virtual void OnHandleContextMenu(HANDLE menu_handle, int align_flags, - const IPC::MiniContextMenuParams& params) = 0; + const IPC::ContextMenuParams& params) = 0; virtual void OnHandleAccelerator(const MSG& accel_message) = 0; virtual void OnTabbedOut(bool reverse) = 0; virtual void OnGoToHistoryOffset(int offset) = 0; @@ -165,7 +165,7 @@ class ExternalTabProxy : public CWindowImpl<ExternalTabProxy>, // Misc. UI. virtual void HandleAccelerator(const MSG& accel_message); virtual void HandleContextMenu(HANDLE menu_handle, int align_flags, - const IPC::MiniContextMenuParams& params); + const IPC::ContextMenuParams& params); virtual void TabbedOut(bool reverse); // Other diff --git a/chrome_frame/external_tab_test.cc b/chrome_frame/external_tab_test.cc index 1448c34..0e49f95 100644 --- a/chrome_frame/external_tab_test.cc +++ b/chrome_frame/external_tab_test.cc @@ -9,7 +9,7 @@ // #include "base/waitable_event.h" -#include "chrome/common/automation_messages.h" +#include "chrome/test/automation/automation_messages.h" #include "testing/gtest/include/gtest/gtest.h" #include "testing/gmock/include/gmock/gmock.h" #include "testing/gmock_mutant.h" @@ -41,7 +41,7 @@ struct MockUIDelegate : public UIDelegate { MOCK_METHOD3(OnMessageFromChromeFrame, void(const std::string& message, const std::string& origin, const std::string& target)); MOCK_METHOD3(OnHandleContextMenu, void(HANDLE menu_handle, int align_flags, - const IPC::MiniContextMenuParams& params)); + const IPC::ContextMenuParams& params)); MOCK_METHOD1(OnHandleAccelerator, void(const MSG& accel_message)); MOCK_METHOD1(OnTabbedOut, void(bool reverse)); MOCK_METHOD1(OnGoToHistoryOffset, void(int offset)); diff --git a/chrome_frame/plugin_url_request.cc b/chrome_frame/plugin_url_request.cc index 236090b..c4bf932 100644 --- a/chrome_frame/plugin_url_request.cc +++ b/chrome_frame/plugin_url_request.cc @@ -4,7 +4,7 @@ #include "chrome_frame/plugin_url_request.h" -#include "chrome/common/automation_messages.h" +#include "chrome/test/automation/automation_messages.h" #include "chrome_frame/np_browser_functions.h" PluginUrlRequest::PluginUrlRequest() diff --git a/chrome_frame/test/automation_client_mock.h b/chrome_frame/test/automation_client_mock.h index 58928b8..2ac30e8 100644 --- a/chrome_frame/test/automation_client_mock.h +++ b/chrome_frame/test/automation_client_mock.h @@ -51,7 +51,7 @@ struct MockCFDelegate : public ChromeFrameDelegateImpl { const std::string& origin, const std::string& target)); MOCK_METHOD4(OnHandleContextMenu, void(int tab_handle, HANDLE menu_handle, - int align_flags, const IPC::MiniContextMenuParams& params)); + int align_flags, const IPC::ContextMenuParams& params)); MOCK_METHOD3(OnRequestStart, void(int tab_handle, int request_id, const IPC::AutomationURLRequest& request)); MOCK_METHOD3(OnRequestRead, void(int tab_handle, int request_id, diff --git a/chrome_frame/test/net/test_automation_provider.cc b/chrome_frame/test/net/test_automation_provider.cc index 5b8a9a6..7594f30 100644 --- a/chrome_frame/test/net/test_automation_provider.cc +++ b/chrome_frame/test/net/test_automation_provider.cc @@ -7,7 +7,7 @@ #include "base/command_line.h" #include "base/file_version_info.h" #include "base/path_service.h" -#include "chrome/common/automation_messages.h" +#include "chrome/test/automation/automation_messages.h" #include "chrome_frame/test/net/test_automation_resource_message_filter.h" namespace { diff --git a/chrome_frame/test/reliability/page_load_test.cc b/chrome_frame/test/reliability/page_load_test.cc index 4116464..482e00e 100644 --- a/chrome_frame/test/reliability/page_load_test.cc +++ b/chrome_frame/test/reliability/page_load_test.cc @@ -37,7 +37,6 @@ #include "chrome/browser/net/url_fixer_upper.h" #include "chrome/browser/prefs/pref_service.h" #include "chrome/browser/prefs/pref_value_store.h" -#include "chrome/common/automation_messages.h" #include "chrome/common/chrome_constants.h" #include "chrome/common/chrome_paths.h" #include "chrome/common/chrome_paths_internal.h" @@ -47,6 +46,7 @@ #include "chrome/common/pref_names.h" #include "chrome_frame/test/chrome_frame_test_utils.h" #include "chrome_frame/test/ie_event_sink.h" +#include "chrome/test/automation/automation_messages.h" #include "chrome/test/automation/automation_proxy.h" #include "chrome/test/automation/browser_proxy.h" #include "chrome/test/automation/tab_proxy.h" |