diff options
| author | rkc@chromium.org <rkc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-30 20:51:37 +0000 |
|---|---|---|
| committer | rkc@chromium.org <rkc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-30 20:51:37 +0000 |
| commit | 47de7230cdd4d2708a4af607249d8f36e368764a (patch) | |
| tree | 765d91a2ea5bdfeb7531dac89165badc546e0215 /chromeos/dbus/cras_audio_client.h | |
| parent | b3a5aeeaa91b682a1d90b131892a21886fcdcc3e (diff) | |
| download | chromium_src-47de7230cdd4d2708a4af607249d8f36e368764a.zip chromium_src-47de7230cdd4d2708a4af607249d8f36e368764a.tar.gz chromium_src-47de7230cdd4d2708a4af607249d8f36e368764a.tar.bz2 | |
Move audio device switching to Chrome.
Currently when a user plugs in (or plugs out) an audio device, cras checks the device priority and various other factors then switches the active device. Move this code to within Chrome. We're doing this primarily to be able to control the volume when an active device switches. We are moving to storing per device volumes in Chrome and we can't switch to the correct volume without a lag time (with the old volume) for a device unless the device switching is done in Chrome.
This CL is still untested - will discuss the changes needed in Cras that I can make locally to test this CL.
R=hshi@chromium.org, satorux@chromium.org
BUG=175798
TEST=Plug in headphones to a device and ensure that the new active device are the headphones.
Review URL: https://codereview.chromium.org/13993031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197462 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chromeos/dbus/cras_audio_client.h')
| -rw-r--r-- | chromeos/dbus/cras_audio_client.h | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/chromeos/dbus/cras_audio_client.h b/chromeos/dbus/cras_audio_client.h index 75e9e7d..4ca0fea 100644 --- a/chromeos/dbus/cras_audio_client.h +++ b/chromeos/dbus/cras_audio_client.h @@ -31,10 +31,10 @@ class CHROMEOS_EXPORT CrasAudioClient { // Called when audio output device volume changed to new value of |volume|. virtual void OutputVolumeChanged(int volume); - // Called whne audio output mute state changed to new state of |mute_on|. + // Called when audio output mute state changed to new state of |mute_on|. virtual void OutputMuteChanged(bool mute_on); - // Called when audio input gain changeg to new value of |gain|. + // Called when audio input gain changes to new value of |gain|. virtual void InputGainChanged(int gain); // Called when audio input mute state changed to new state of |mute_on|. @@ -90,10 +90,10 @@ class CHROMEOS_EXPORT CrasAudioClient { // Sets input mute state to |mute_on| value. virtual void SetInputMute(bool mute_on) = 0; - // Sets the active output noe to |node_id|. + // Sets the active output node to |node_id|. virtual void SetActiveOutputNode(uint64 node_id) = 0; - // Sets the active input noe to |node_id|. + // Sets the active input node to |node_id|. virtual void SetActiveInputNode(uint64 node_id) = 0; // Creates the instance. |