diff options
| author | pneubeck@chromium.org <pneubeck@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-03 09:59:45 +0000 |
|---|---|---|
| committer | pneubeck@chromium.org <pneubeck@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-03 09:59:45 +0000 |
| commit | 6489b459d871f319d20c1ba37aa0ac2ed8bed78a (patch) | |
| tree | 19cac61fca2f519cf5c7986e09b82f44218769c5 /chromeos/dbus/nfc_client_unittest.cc | |
| parent | 5d2cfdfe2bf4a5010fb00f8f03bf277d14f5641c (diff) | |
| download | chromium_src-6489b459d871f319d20c1ba37aa0ac2ed8bed78a.zip chromium_src-6489b459d871f319d20c1ba37aa0ac2ed8bed78a.tar.gz chromium_src-6489b459d871f319d20c1ba37aa0ac2ed8bed78a.tar.bz2 | |
Remove fake client creation from DBusClients' Create() functions.
The DBusClient interfaces shouldn't provide functionality related to testing code (like Stubs/fake implementations).
Instead fake clients are now directly created without relying on the static Create() functions. The now unused DBusClientImplementationType argument of the Create() functions could be removed.
BUG=275286
R=satorux@chromium.org
Review URL: https://codereview.chromium.org/91413002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238330 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chromeos/dbus/nfc_client_unittest.cc')
| -rw-r--r-- | chromeos/dbus/nfc_client_unittest.cc | 18 |
1 files changed, 5 insertions, 13 deletions
diff --git a/chromeos/dbus/nfc_client_unittest.cc b/chromeos/dbus/nfc_client_unittest.cc index 94d7628..ed45c72 100644 --- a/chromeos/dbus/nfc_client_unittest.cc +++ b/chromeos/dbus/nfc_client_unittest.cc @@ -201,20 +201,12 @@ class NfcClientTest : public testing::Test { EXPECT_CALL(*mock_bus_.get(), ShutdownAndBlock()).WillOnce(Return()); // Create the clients. - manager_client_.reset( - NfcManagerClient::Create(REAL_DBUS_CLIENT_IMPLEMENTATION)); - adapter_client_.reset( - NfcAdapterClient::Create(REAL_DBUS_CLIENT_IMPLEMENTATION, - manager_client_.get())); - device_client_.reset( - NfcDeviceClient::Create(REAL_DBUS_CLIENT_IMPLEMENTATION, - adapter_client_.get())); - tag_client_.reset( - NfcTagClient::Create(REAL_DBUS_CLIENT_IMPLEMENTATION, - adapter_client_.get())); + manager_client_.reset(NfcManagerClient::Create()); + adapter_client_.reset(NfcAdapterClient::Create(manager_client_.get())); + device_client_.reset(NfcDeviceClient::Create(adapter_client_.get())); + tag_client_.reset(NfcTagClient::Create(adapter_client_.get())); record_client_.reset( - NfcRecordClient::Create(REAL_DBUS_CLIENT_IMPLEMENTATION, - device_client_.get(), tag_client_.get())); + NfcRecordClient::Create(device_client_.get(), tag_client_.get())); manager_client_->Init(mock_bus_.get()); adapter_client_->Init(mock_bus_.get()); device_client_->Init(mock_bus_.get()); |