chromeos: Add test for DiskInfo::DiskInfo()

Code stack of CrosDisksClient, DiskMountManager and FileManagerEventRouter need some refactoring, but most of the code lack tests.

BUG=None
TEST=chromeos_unittests
R=satorux@chromium.org

Review URL: https://codereview.chromium.org/18734002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210350 0039d316-1c4b-4281-b951-d872f2087c98

2 files changed, 143 insertions, 1 deletions

diff --git a/chromeos/dbus/cros_disks_client.h b/chromeos/dbus/cros_disks_client.h
index 4d06bbe..1d786c9 100644
--- a/chromeos/dbus/cros_disks_client.h
+++ b/chromeos/dbus/cros_disks_client.h
@@ -103,7 +103,7 @@ enum UnmountOptions {
 };
 
 // A class to represent information about a disk sent from cros-disks.
-class DiskInfo {
+class CHROMEOS_EXPORT DiskInfo {
  public:
   DiskInfo(const std::string& device_path, dbus::Response* response);
   ~DiskInfo();
diff --git a/chromeos/dbus/cros_disks_client_unittest.cc b/chromeos/dbus/cros_disks_client_unittest.cc
new file mode 100644
index 0000000..91abc8f
--- /dev/null
+++ b/chromeos/dbus/cros_disks_client_unittest.cc
@@ -0,0 +1,142 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chromeos/dbus/cros_disks_client.h"
+
+#include "base/memory/scoped_ptr.h"
+#include "dbus/message.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "third_party/cros_system_api/dbus/service_constants.h"
+
+namespace chromeos {
+
+namespace {
+
+// Appends a boolean entry to a dictionary of type "a{sv}"
+void AppendBoolDictEntry(dbus::MessageWriter* array_writer,
+                         const std::string& key,
+                         bool value) {
+  dbus::MessageWriter entry_writer(NULL);
+  array_writer->OpenDictEntry(&entry_writer);
+  entry_writer.AppendString(key);
+  entry_writer.AppendVariantOfBool(value);
+  array_writer->CloseContainer(&entry_writer);
+}
+
+// Appends a string entry to a dictionary of type "a{sv}"
+void AppendStringDictEntry(dbus::MessageWriter* array_writer,
+                           const std::string& key,
+                           const std::string& value) {
+  dbus::MessageWriter entry_writer(NULL);
+  array_writer->OpenDictEntry(&entry_writer);
+  entry_writer.AppendString(key);
+  entry_writer.AppendVariantOfString(value);
+  array_writer->CloseContainer(&entry_writer);
+}
+
+}  // namespace
+
+TEST(CrosDisksClientTest, DiskInfo) {
+  const std::string kDeviceFile = "/dev/sdb1";
+  const bool kDeviceIsDrive = true;
+  const bool kDeviceIsMediaAvailable = true;
+  const bool kDeviceIsMounted = true;
+  const bool kDeviceIsOnBootDevice = true;
+  const bool kDeviceIsReadOnly = true;
+  const uint32 kDeviceMediaType = cros_disks::DEVICE_MEDIA_SD;
+  const std::string kMountPath = "/media/removable/UNTITLED";
+  const bool kDevicePresentationHide = false;
+  const uint64 kDeviceSize = 16005464064;
+  const std::string kDriveModel = "DriveModel";
+  const std::string kIdLabel = "UNTITLED";
+  const std::string kIdUuid = "XXXX-YYYY";
+  const std::string kNativePath = "/sys/devices/.../sdb/sdb1";
+  const std::string kProductId = "1234";
+  const std::string kProductName = "Product Name";
+  const std::string kVendorId = "0000";
+  const std::string kVendorName = "Vendor Name";
+
+  // Construct a fake response of GetDeviceProperties().
+  scoped_ptr<dbus::Response> response(dbus::Response::CreateEmpty());
+  {
+    dbus::MessageWriter writer(response.get());
+    dbus::MessageWriter array_writer(NULL);
+    writer.OpenArray("{sv}", &array_writer);
+
+    AppendStringDictEntry(&array_writer, cros_disks::kDeviceFile, kDeviceFile);
+    AppendBoolDictEntry(&array_writer, cros_disks::kDeviceIsDrive,
+                        kDeviceIsDrive);
+    AppendBoolDictEntry(&array_writer, cros_disks::kDeviceIsMediaAvailable,
+                        kDeviceIsMediaAvailable);
+    AppendBoolDictEntry(&array_writer, cros_disks::kDeviceIsMounted,
+                        kDeviceIsMounted);
+    AppendBoolDictEntry(&array_writer, cros_disks::kDeviceIsOnBootDevice,
+                        kDeviceIsOnBootDevice);
+    AppendBoolDictEntry(&array_writer, cros_disks::kDeviceIsReadOnly,
+                        kDeviceIsReadOnly);
+    {
+      dbus::MessageWriter entry_writer(NULL);
+      array_writer.OpenDictEntry(&entry_writer);
+      entry_writer.AppendString(cros_disks::kDeviceMediaType);
+      entry_writer.AppendVariantOfUint32(kDeviceMediaType);
+      array_writer.CloseContainer(&entry_writer);
+    }
+    {
+      std::vector<std::string> mounted_paths;
+      mounted_paths.push_back(kMountPath);
+
+      dbus::MessageWriter entry_writer(NULL);
+      array_writer.OpenDictEntry(&entry_writer);
+      entry_writer.AppendString(cros_disks::kDeviceMountPaths);
+      dbus::MessageWriter variant_writer(NULL);
+      entry_writer.OpenVariant("as", &variant_writer);
+      variant_writer.AppendArrayOfStrings(mounted_paths);
+      entry_writer.CloseContainer(&variant_writer);
+      array_writer.CloseContainer(&entry_writer);
+    }
+    AppendBoolDictEntry(&array_writer, cros_disks::kDevicePresentationHide,
+                        kDevicePresentationHide);
+    {
+      dbus::MessageWriter entry_writer(NULL);
+      array_writer.OpenDictEntry(&entry_writer);
+      entry_writer.AppendString(cros_disks::kDeviceSize);
+      entry_writer.AppendVariantOfUint64(kDeviceSize);
+      array_writer.CloseContainer(&entry_writer);
+    }
+    AppendStringDictEntry(&array_writer, cros_disks::kDriveModel, kDriveModel);
+    AppendStringDictEntry(&array_writer, cros_disks::kIdLabel, kIdLabel);
+    AppendStringDictEntry(&array_writer, cros_disks::kIdUuid, kIdUuid);
+    AppendStringDictEntry(&array_writer, cros_disks::kNativePath, kNativePath);
+    AppendStringDictEntry(&array_writer, cros_disks::kProductId, kProductId);
+    AppendStringDictEntry(&array_writer, cros_disks::kProductName,
+                          kProductName);
+    AppendStringDictEntry(&array_writer, cros_disks::kVendorId, kVendorId);
+    AppendStringDictEntry(&array_writer, cros_disks::kVendorName, kVendorName);
+
+    writer.CloseContainer(&array_writer);
+  }
+
+  // Construct DiskInfo.
+  DiskInfo result(kDeviceFile, response.get());
+  EXPECT_EQ(kDeviceFile, result.device_path());
+  EXPECT_EQ(kDeviceIsDrive, result.is_drive());
+  EXPECT_EQ(kDeviceIsReadOnly, result.is_read_only());
+  EXPECT_EQ(kDevicePresentationHide, result.is_hidden());
+  EXPECT_EQ(kDeviceIsMediaAvailable, result.has_media());
+  EXPECT_EQ(kDeviceIsOnBootDevice, result.on_boot_device());
+  EXPECT_EQ(kNativePath, result.system_path());
+  EXPECT_EQ(kDeviceFile, result.file_path());
+  EXPECT_EQ(kVendorId, result.vendor_id());
+  EXPECT_EQ(kVendorName, result.vendor_name());
+  EXPECT_EQ(kProductId, result.product_id());
+  EXPECT_EQ(kProductName, result.product_name());
+  EXPECT_EQ(kDriveModel, result.drive_label());
+  EXPECT_EQ(kIdLabel, result.label());
+  EXPECT_EQ(kIdUuid, result.uuid());
+  EXPECT_EQ(kDeviceSize, result.total_size_in_bytes());
+  EXPECT_EQ(DEVICE_TYPE_SD, result.device_type());
+  EXPECT_EQ(kMountPath, result.mount_path());
+}
+
+}  // namespace chromeos