diff options
author | nona@chromium.org <nona@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-11-06 10:14:53 +0000 |
---|---|---|
committer | nona@chromium.org <nona@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-11-06 10:14:53 +0000 |
commit | bfdd5c40a2e31b52cda6b1bb782eadb286f6f2d5 (patch) | |
tree | 0390d871a03e62c9ba7177e1b15245c0908ee942 /chromeos | |
parent | f4302c50dc96d5b883d6e6b9e8245ece03249713 (diff) | |
download | chromium_src-bfdd5c40a2e31b52cda6b1bb782eadb286f6f2d5.zip chromium_src-bfdd5c40a2e31b52cda6b1bb782eadb286f6f2d5.tar.gz chromium_src-bfdd5c40a2e31b52cda6b1bb782eadb286f6f2d5.tar.bz2 |
Add annotation/description member into LookupTable entry.
We can't write unittest for these because AppendIBusText does not support attachment field.
BUG=129403
TEST=ran chromeos_unittests and manually done
Review URL: https://chromiumcodereview.appspot.com/11365105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166183 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chromeos')
-rw-r--r-- | chromeos/dbus/ibus/ibus_lookup_table.cc | 14 | ||||
-rw-r--r-- | chromeos/dbus/ibus/ibus_lookup_table.h | 4 |
2 files changed, 15 insertions, 3 deletions
diff --git a/chromeos/dbus/ibus/ibus_lookup_table.cc b/chromeos/dbus/ibus/ibus_lookup_table.cc index 21b894a..2a926f1 100644 --- a/chromeos/dbus/ibus/ibus_lookup_table.cc +++ b/chromeos/dbus/ibus/ibus_lookup_table.cc @@ -151,15 +151,17 @@ bool PopIBusLookupTable(dbus::MessageReader* reader, IBusLookupTable* table) { std::vector<IBusLookupTable::Entry>* candidates = table->mutable_candidates(); while (text_array_reader.HasMoreData()) { - std::string candidate_text; + ibus::IBusText candidate_text; // The attributes in IBusText are not used in Chrome. - if (!PopStringFromIBusText(&text_array_reader, &candidate_text)) { + if (!PopIBusText(&text_array_reader, &candidate_text)) { LOG(ERROR) << "Invalid variant structure[IBusLookupTable]: " << "6th argument should be array of IBusText."; return false; } IBusLookupTable::Entry entry; - entry.value = candidate_text; + entry.value = candidate_text.text(); + entry.annotation = candidate_text.annotation(); + entry.description = candidate_text.description(); candidates->push_back(entry); } @@ -206,5 +208,11 @@ IBusLookupTable::IBusLookupTable() IBusLookupTable::~IBusLookupTable() { } +IBusLookupTable::Entry::Entry() { +} + +IBusLookupTable::Entry::~Entry() { +} + } // namespace ibus } // namespace chromeos diff --git a/chromeos/dbus/ibus/ibus_lookup_table.h b/chromeos/dbus/ibus/ibus_lookup_table.h index d8abfd9..73d11bd 100644 --- a/chromeos/dbus/ibus/ibus_lookup_table.h +++ b/chromeos/dbus/ibus/ibus_lookup_table.h @@ -90,8 +90,12 @@ class CHROMEOS_EXPORT IBusLookupTable { // field is represented as IBusText, but attributes are not used in Chrome. // So just simple string is sufficient in this case. struct Entry { + Entry(); + virtual ~Entry(); std::string value; std::string label; + std::string annotation; + std::string description; }; IBusLookupTable(); |