summaryrefslogtreecommitdiffstats
path: root/cloud_print
diff options
context:
space:
mode:
authordcheng <dcheng@chromium.org>2015-10-09 18:17:26 -0700
committerCommit bot <commit-bot@chromium.org>2015-10-10 01:18:27 +0000
commit7764fe9ea52233096b7916614eb7c60b26bbca05 (patch)
tree0f7d3570c76e7387f1f329045c55fe70cce69971 /cloud_print
parentfbe0354f403ff793ccacd4d1e162583c11bd58db (diff)
downloadchromium_src-7764fe9ea52233096b7916614eb7c60b26bbca05.zip
chromium_src-7764fe9ea52233096b7916614eb7c60b26bbca05.tar.gz
chromium_src-7764fe9ea52233096b7916614eb7c60b26bbca05.tar.bz2
Enforce WARN_UNUSED_RESULT attribute on Windows
BUG=none R=cpu,danakj,dpranke,hans,kelvinp,rickyz,sky,sorin,thestig,tuttle,yukawa TBR=vitalybuka Review URL: https://codereview.chromium.org/1390223002 Cr-Commit-Position: refs/heads/master@{#353450}
Diffstat (limited to 'cloud_print')
-rw-r--r--cloud_print/service/win/service_listener.cc3
-rw-r--r--cloud_print/service/win/setup_listener.cc3
2 files changed, 4 insertions, 2 deletions
diff --git a/cloud_print/service/win/service_listener.cc b/cloud_print/service/win/service_listener.cc
index 52d8ab8..31173c7 100644
--- a/cloud_print/service/win/service_listener.cc
+++ b/cloud_print/service/win/service_listener.cc
@@ -96,7 +96,8 @@ void ServiceListener::Connect() {
// need for an attachment broker.
channel_ =
IPC::Channel::CreateClient(IPC::ChannelHandle(handle.Get()), this);
- channel_->Connect();
+ bool connected = channel_->Connect();
+ DCHECK(connected);
} else {
ipc_thread_->message_loop()->PostDelayedTask(
FROM_HERE,
diff --git a/cloud_print/service/win/setup_listener.cc b/cloud_print/service/win/setup_listener.cc
index 67cb85b..c4ffc79 100644
--- a/cloud_print/service/win/setup_listener.cc
+++ b/cloud_print/service/win/setup_listener.cc
@@ -119,7 +119,8 @@ void SetupListener::Connect(const base::string16& user) {
if (pipe.IsValid()) {
channel_ = IPC::Channel::CreateServer(IPC::ChannelHandle(pipe.Get()),
this);
- channel_->Connect();
+ if (!channel_->Connect())
+ done_event_->Signal();
}
}