diff options
author | gcasto@chromium.org <gcasto@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-03-04 05:53:20 +0000 |
---|---|---|
committer | gcasto@chromium.org <gcasto@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-03-04 05:53:20 +0000 |
commit | 2e26ca1c584b007a85529904a7e55bd363ed46a2 (patch) | |
tree | 0cbd9cf138b5f99300a4f58d10a913335d163191 /components/autofill/content | |
parent | b5fb96d693a8517e19026653ab732a24685b19c4 (diff) | |
download | chromium_src-2e26ca1c584b007a85529904a7e55bd363ed46a2.zip chromium_src-2e26ca1c584b007a85529904a7e55bd363ed46a2.tar.gz chromium_src-2e26ca1c584b007a85529904a7e55bd363ed46a2.tar.bz2 |
[Password Generation] Start removing old UI
This code in particular has been buggy in the past and is now no longer
used for its original purpose.
BUG=295698,347777
Review URL: https://codereview.chromium.org/184033003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254684 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'components/autofill/content')
-rw-r--r-- | components/autofill/content/renderer/password_generation_agent.cc | 16 | ||||
-rw-r--r-- | components/autofill/content/renderer/password_generation_agent.h | 7 |
2 files changed, 1 insertions, 22 deletions
diff --git a/components/autofill/content/renderer/password_generation_agent.cc b/components/autofill/content/renderer/password_generation_agent.cc index 4949f8e..c81c154 100644 --- a/components/autofill/content/renderer/password_generation_agent.cc +++ b/components/autofill/content/renderer/password_generation_agent.cc @@ -104,7 +104,6 @@ PasswordGenerationAgent::PasswordGenerationAgent( password_edited_(false), enabled_(password_generation::IsPasswordGenerationEnabled()) { DVLOG(2) << "Password Generation is " << (enabled_ ? "Enabled" : "Disabled"); - render_view_->GetWebView()->setPasswordGeneratorClient(this); } PasswordGenerationAgent::~PasswordGenerationAgent() {} @@ -190,21 +189,6 @@ bool PasswordGenerationAgent::ShouldAnalyzeDocument( return true; } -void PasswordGenerationAgent::openPasswordGenerator( - blink::WebInputElement& element) { - blink::WebElement button(element.passwordGeneratorButtonElement()); - gfx::Rect rect(button.boundsInViewportSpace()); - scoped_ptr<PasswordForm> password_form( - CreatePasswordForm(element.form())); - // We should not have shown the icon we can't create a valid PasswordForm. - DCHECK(password_form.get()); - - Send(new AutofillHostMsg_ShowPasswordGenerationPopup(routing_id(), - rect, - element.maxLength(), - *password_form)); -} - bool PasswordGenerationAgent::OnMessageReceived(const IPC::Message& message) { bool handled = true; IPC_BEGIN_MESSAGE_MAP(PasswordGenerationAgent, message) diff --git a/components/autofill/content/renderer/password_generation_agent.h b/components/autofill/content/renderer/password_generation_agent.h index dcb0b19..3179d6a 100644 --- a/components/autofill/content/renderer/password_generation_agent.h +++ b/components/autofill/content/renderer/password_generation_agent.h @@ -12,7 +12,6 @@ #include "base/memory/scoped_ptr.h" #include "content/public/renderer/render_view_observer.h" #include "third_party/WebKit/public/web/WebInputElement.h" -#include "third_party/WebKit/public/web/WebPasswordGeneratorClient.h" #include "url/gurl.h" namespace blink { @@ -28,8 +27,7 @@ struct PasswordForm; // This class is responsible for controlling communication for password // generation between the browser (which shows the popup and generates // passwords) and WebKit (shows the generation icon in the password field). -class PasswordGenerationAgent : public content::RenderViewObserver, - public blink::WebPasswordGeneratorClient { +class PasswordGenerationAgent : public content::RenderViewObserver { public: explicit PasswordGenerationAgent(content::RenderView* render_view); virtual ~PasswordGenerationAgent(); @@ -55,9 +53,6 @@ class PasswordGenerationAgent : public content::RenderViewObserver, virtual void DidFinishLoad(blink::WebFrame* frame) OVERRIDE; virtual void FocusedNodeChanged(const blink::WebNode& node) OVERRIDE; - // WebPasswordGeneratorClient: - virtual void openPasswordGenerator(blink::WebInputElement& element) OVERRIDE; - // Message handlers. void OnFormNotBlacklisted(const PasswordForm& form); void OnPasswordAccepted(const base::string16& password); |