diff options
| author | rkc <rkc@chromium.org> | 2014-10-22 19:39:03 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-10-23 02:39:53 +0000 |
| commit | a05223cb296cb5301f043d10867c027aa56ebff3 (patch) | |
| tree | 64b05b743845a23a4a2db65f803f6cc16661c25d /components/components_tests.gyp | |
| parent | ffe86abe341d7cd81281670e26adcfaef6f2a176 (diff) | |
| download | chromium_src-a05223cb296cb5301f043d10867c027aa56ebff3.zip chromium_src-a05223cb296cb5301f043d10867c027aa56ebff3.tar.gz chromium_src-a05223cb296cb5301f043d10867c027aa56ebff3.tar.bz2 | |
Redesign the copresence audio handlers.
Since playback and recording were baked directly into the audio directive
handling code, it is really hard to implement features that control audio
playback independent of directive management - for example, carrier sense,
audio playback verification, etc.
This CL first, introduces a new class which abstracts the details of actual
playback and recording, then it refactors and redesigns a lot of the audio
code to make directive handling much simpler and makes the audible and
inaudible audio handling much cleaner. This also fixes the issue of us always
decoding both audible and inaudible tokens at the same time, despite the kind
of token we got.
Reviews requested,
derat, xiyuan - general
kalman - copresence_private.idl
R=derat@chromium.org, kalman@chromium.org, xiyuan@chromium.org
BUG=407621,390388,388499
Review URL: https://codereview.chromium.org/637223011
Cr-Commit-Position: refs/heads/master@{#300825}
Diffstat (limited to 'components/components_tests.gyp')
| -rw-r--r-- | components/components_tests.gyp | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/components/components_tests.gyp b/components/components_tests.gyp index 524a565..dbeb874 100644 --- a/components/components_tests.gyp +++ b/components/components_tests.gyp @@ -669,6 +669,7 @@ 'sources': [ 'copresence/handlers/audio/audio_directive_handler_unittest.cc', 'copresence/handlers/audio/audio_directive_list_unittest.cc', + 'copresence/mediums/audio/audio_manager_unittest.cc', 'copresence/mediums/audio/audio_player_unittest.cc', 'copresence/mediums/audio/audio_recorder_unittest.cc', 'copresence/rpc/http_post_unittest.cc', |