summaryrefslogtreecommitdiffstats
path: root/components/crx_file
diff options
context:
space:
mode:
authorbrettw <brettw@chromium.org>2015-08-10 12:07:51 -0700
committerCommit bot <commit-bot@chromium.org>2015-08-10 19:08:31 +0000
commitfce8d19805ad83a006bbdd3ca68fc9d8eca621e6 (patch)
tree53b8fca581ffa89718788efe7a4295a662554d03 /components/crx_file
parenta794ba10af6e3ac6d4661a2edc6f8d60642218af (diff)
downloadchromium_src-fce8d19805ad83a006bbdd3ca68fc9d8eca621e6.zip
chromium_src-fce8d19805ad83a006bbdd3ca68fc9d8eca621e6.tar.gz
chromium_src-fce8d19805ad83a006bbdd3ca68fc9d8eca621e6.tar.bz2
Replace ToLower calls to the new format
Replaces base::StringToLowerASCII(string) with base::ToLowerASCII(string) This form is 1:1 search and replace. A bunch of places did something like this: std::string foo(something_else); base::StringToLowerASCII(&foo); which became: foo = base::ToLowerASCII(something_else); A couple places really wanted in-place changing and they became: foo = base::ToLowerASCII(foo); There was pretty trivial cleanup in chrome_main_delegate.cc chrome/test/chromedriver/server/http_handler.cc (fix indenting). There was more cleanup in: chrome/installer/util/language_selector.cc and components/plugins/renderer/mobile_youtube_plugin.cc In components/history/core/browser/url_utils.cc I removed the call since it was calling ToLower on the host name out of a GURL, which is already guaranteed to be lower-case. NOPRESUBMIT=true (due to touching code with wstrings) Review URL: https://codereview.chromium.org/1279123004 Cr-Commit-Position: refs/heads/master@{#342659}
Diffstat (limited to 'components/crx_file')
-rw-r--r--components/crx_file/crx_file.cc2
-rw-r--r--components/crx_file/id_util.cc4
2 files changed, 3 insertions, 3 deletions
diff --git a/components/crx_file/crx_file.cc b/components/crx_file/crx_file.cc
index b081fec..ace6ee1 100644
--- a/components/crx_file/crx_file.cc
+++ b/components/crx_file/crx_file.cc
@@ -61,7 +61,7 @@ CrxFile::ValidateError FinalizeHash(const std::string& extension_id,
uint8 output[crypto::kSHA256Length] = {};
hash->Finish(output, sizeof(output));
std::string hash_base64 =
- base::StringToLowerASCII(base::HexEncode(output, sizeof(output)));
+ base::ToLowerASCII(base::HexEncode(output, sizeof(output)));
if (hash_base64 != expected_hash) {
LOG(ERROR) << "Hash check failed for extension: " << extension_id
<< ", expected " << expected_hash << ", got " << hash_base64;
diff --git a/components/crx_file/id_util.cc b/components/crx_file/id_util.cc
index 6209cb4..d628aa1 100644
--- a/components/crx_file/id_util.cc
+++ b/components/crx_file/id_util.cc
@@ -40,7 +40,7 @@ std::string GenerateId(const std::string& input) {
uint8 hash[kIdSize];
crypto::SHA256HashString(input, hash, sizeof(hash));
std::string output =
- base::StringToLowerASCII(base::HexEncode(hash, sizeof(hash)));
+ base::ToLowerASCII(base::HexEncode(hash, sizeof(hash)));
ConvertHexadecimalToIDAlphabet(&output);
return output;
@@ -83,7 +83,7 @@ bool IdIsValid(const std::string& id) {
// We only support lowercase IDs, because IDs can be used as URL components
// (where GURL will lowercase it).
- std::string temp = base::StringToLowerASCII(id);
+ std::string temp = base::ToLowerASCII(id);
for (size_t i = 0; i < temp.size(); i++)
if (temp[i] < 'a' || temp[i] > 'p')
return false;