diff options
| author | yzshen <yzshen@chromium.org> | 2015-06-09 13:59:54 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-06-09 21:00:23 +0000 |
| commit | 2008a972161fbf2359fe77c67d16f36539f8098b (patch) | |
| tree | 11a8b435fa1fad26dd951b1c999571f42b0dbda5 /components/devtools_service | |
| parent | 256970e9870d7f6eac0eae1d912a8cb6dc588bfa (diff) | |
| download | chromium_src-2008a972161fbf2359fe77c67d16f36539f8098b.zip chromium_src-2008a972161fbf2359fe77c67d16f36539f8098b.tar.gz chromium_src-2008a972161fbf2359fe77c67d16f36539f8098b.tar.bz2 | |
Revert of html_viewer: Add DevToolsAgentImpl. (patchset #5 id:80001 of https://codereview.chromium.org/1163953002/)
Reason for revert:
Maybe the reason of the html_viewer_apptests flakiness:
http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Linux/builds/9552
Running mojo:html_viewer_apptests...
DEBUG:Tests for mojo:html_viewer_apptests:
AXProviderTest.
HelloWorld
DEBUG:Command: /mnt/data/b/build/slave/chromium_mojo/build/src/out/Release/mojo_runner --gtest_filter=AXProviderTest.HelloWorld mojo:html_viewer_apptests
[ FAILED ] Command (exit code -11): /mnt/data/b/build/slave/chromium_mojo/build/src/out/Release/mojo_runner --gtest_filter=AXProviderTest.HelloWorld mojo:html_viewer_apptests
Original issue's description:
> html_viewer: Add DevToolsAgentImpl.
>
> DevToolsAgentImpl connects the DevTools mojo service with the DevTools agent support in blink.
>
> BUG=478249
>
> Committed: https://crrev.com/32166090d27c6450957f59eedaa6ea5fa12762e4
> Cr-Commit-Position: refs/heads/master@{#333516}
TBR=sky@chromium.org,dgozman@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=478249
Review URL: https://codereview.chromium.org/1172123002
Cr-Commit-Position: refs/heads/master@{#333570}
Diffstat (limited to 'components/devtools_service')
| -rw-r--r-- | components/devtools_service/public/interfaces/devtools_service.mojom | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/components/devtools_service/public/interfaces/devtools_service.mojom b/components/devtools_service/public/interfaces/devtools_service.mojom index 80a2ad8..5f7b454 100644 --- a/components/devtools_service/public/interfaces/devtools_service.mojom +++ b/components/devtools_service/public/interfaces/devtools_service.mojom @@ -30,7 +30,7 @@ interface DevToolsAgent { // DispatchProtocolMessage() calls. If a client doesn't want to receive // messages anymore, it could simply close the underlying message pipe of // |client|. - SetClient(DevToolsAgentClient client, string client_id); + SetClient(DevToolsAgentClient client); // Sends a command (in remote debugging protocol JSON format) to the agent. DispatchProtocolMessage(string message); |