diff options
| author | hayato <hayato@chromium.org> | 2015-03-30 20:14:09 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-03-31 03:14:56 +0000 |
| commit | c7c707f533da81e7c7d5c2201426ae60e4a0daf7 (patch) | |
| tree | f3f148090ef1c9e5b78842443f39c81a0f8fcc90 /components/favicon.gypi | |
| parent | 4988e439c1a14779f32b4dc9c289d9e4bad467af (diff) | |
| download | chromium_src-c7c707f533da81e7c7d5c2201426ae60e4a0daf7.zip chromium_src-c7c707f533da81e7c7d5c2201426ae60e4a0daf7.tar.gz chromium_src-c7c707f533da81e7c7d5c2201426ae60e4a0daf7.tar.bz2 | |
Revert of Move //components/favicon code into the favicon namespace (patchset #4 id:80001 of https://codereview.chromium.org/1028503004/)
Reason for revert:
Blink gardening. Speculative revert for Blink layout test failures in WebKit Mac10.8 (retina):
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.8%20%28retina%29/builds/27696
chromium range: chromium revision 322799:322813
https://chromium.googlesource.com/chromium/src/+log/494aec68691f10626b226892396d442503dd9af7%5E..e240ab4e9c5841de8cb65226a80008600416c365?pretty=fuller
Original issue's description:
> Move //components/favicon code into the favicon namespace
>
> Move all classes defined in //components/favicon into the favicon namespace
> and update all client code forward-declaration and usage.
>
> Rename FaviconTabHelperObserver to FaviconDriverObserver as FaviconDriver is
> the name of the base interface (and iOS wants to use that observer but will
> not be able to use FaviconTabHelper).
>
> BUG=359513
>
> Committed: https://crrev.com/494aec68691f10626b226892396d442503dd9af7
> Cr-Commit-Position: refs/heads/master@{#322799}
TBR=sky@chromium.org,sdefresne@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=359513
Review URL: https://codereview.chromium.org/1045823004
Cr-Commit-Position: refs/heads/master@{#322969}
Diffstat (limited to 'components/favicon.gypi')
| -rw-r--r-- | components/favicon.gypi | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/components/favicon.gypi b/components/favicon.gypi index d1aa277..8a9378b 100644 --- a/components/favicon.gypi +++ b/components/favicon.gypi @@ -24,11 +24,11 @@ 'favicon/core/fallback_icon_service.h', 'favicon/core/favicon_client.h', 'favicon/core/favicon_driver.h', - 'favicon/core/favicon_driver_observer.h', 'favicon/core/favicon_handler.cc', 'favicon/core/favicon_handler.h', 'favicon/core/favicon_service.cc', 'favicon/core/favicon_service.h', + 'favicon/core/favicon_tab_helper_observer.h', 'favicon/core/favicon_url.cc', 'favicon/core/favicon_url.h', ], |