diff options
| author | sdefresne <sdefresne@chromium.org> | 2015-03-16 09:56:03 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-03-16 16:56:41 +0000 |
| commit | fee69b4b384e94f03cd7d4dadf3140dd91bb9029 (patch) | |
| tree | dc8bfb0c7de3326ed467998f34a5427f3eacf60d /components/favicon.gypi | |
| parent | ee5ad4b13cc36b7ee494bc2b04a356d73ad32e3a (diff) | |
| download | chromium_src-fee69b4b384e94f03cd7d4dadf3140dd91bb9029.zip chromium_src-fee69b4b384e94f03cd7d4dadf3140dd91bb9029.tar.gz chromium_src-fee69b4b384e94f03cd7d4dadf3140dd91bb9029.tar.bz2 | |
Componentize FaviconService and FaviconHandler
Move FaviconService and FaviconHandler into //components/favicon/core/browser
as they have no problematic dependencies anymore.
Update DEPS and dependencies of favicon component.
BUG=359514,359513
Review URL: https://codereview.chromium.org/983043003
Cr-Commit-Position: refs/heads/master@{#320738}
Diffstat (limited to 'components/favicon.gypi')
| -rw-r--r-- | components/favicon.gypi | 30 |
1 files changed, 28 insertions, 2 deletions
diff --git a/components/favicon.gypi b/components/favicon.gypi index 262bd2b4..09a78f2 100644 --- a/components/favicon.gypi +++ b/components/favicon.gypi @@ -10,12 +10,11 @@ 'type': 'static_library', 'dependencies': [ '../ui/gfx/gfx.gyp:gfx_geometry', + '../url/url.gyp:url_lib', 'favicon_base', - 'keyed_service_core', ], 'sources': [ # Note: sources list duplicated in GN build. - 'favicon/core/browser/favicon_client.h', 'favicon/core/favicon_driver.h', 'favicon/core/favicon_url.cc', 'favicon/core/favicon_url.h', @@ -24,5 +23,32 @@ '..', ], }, + { + # GN version: //components/favicon/core/browser + 'target_name': 'favicon_core_browser', + 'type': 'static_library', + 'dependencies': [ + '../skia/skia.gyp:skia', + '../ui/gfx/gfx.gyp:gfx', + '../url/url.gyp:url_lib', + 'bookmarks_browser', + 'favicon_base', + 'favicon_core', + 'history_core_browser', + 'keyed_service_core', + ], + 'sources': [ + # Note: sources list duplicated in GN build. + 'favicon/core/browser/favicon_client.h', + 'favicon/core/browser/favicon_handler.cc', + 'favicon/core/browser/favicon_handler.h', + 'favicon/core/browser/favicon_service.cc', + 'favicon/core/browser/favicon_service.h', + 'favicon/core/browser/favicon_tab_helper_observer.h', + ], + 'include_dirs': [ + '..', + ], + }, ], } |