diff options
| author | vitalybuka <vitalybuka@chromium.org> | 2015-02-02 17:46:45 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-02-03 01:48:04 +0000 |
| commit | 014d6bff6fb63d89847be0431aaaa985a852801c (patch) | |
| tree | db81a2ef06f9a6a38278e981644ee3b8775d3738 /components/history.gypi | |
| parent | 259fd3ded173e9c932bf2f2dcdb4e11f5aa959d9 (diff) | |
| download | chromium_src-014d6bff6fb63d89847be0431aaaa985a852801c.zip chromium_src-014d6bff6fb63d89847be0431aaaa985a852801c.tar.gz chromium_src-014d6bff6fb63d89847be0431aaaa985a852801c.tar.bz2 | |
Revert of Componentize WebHistoryService (patchset #4 id:60001 of https://codereview.chromium.org/882753002/)
Reason for revert:
BUG=454524
Original issue's description:
> Componentize WebHistoryService
>
> Instead of using the factories to retrieve the dependended upon keyed service,
> pass them explicitly to WebHistoryService from the WebHistoryServiceFactory.
>
> Fix the dependency of WebHistoryService to add the service used and to remove
> the service unused.
>
> Move file into //components/history/core/browser, remove unnecessary #include
> and fix files that did not #include all the files they used.
>
> BUG=371835
>
> Committed: https://crrev.com/12dabec1af75b80952821fee2f37a28637fa15b7
> Cr-Commit-Position: refs/heads/master@{#313926}
TBR=droger@chromium.org,jhawkins@chromium.org,rlp@chromium.org,rogerta@chromium.org,sdefresne@chromium.org
NOPRESUBMIT=true
BUG=371835
Review URL: https://codereview.chromium.org/889553003
Cr-Commit-Position: refs/heads/master@{#314240}
Diffstat (limited to 'components/history.gypi')
| -rw-r--r-- | components/history.gypi | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/components/history.gypi b/components/history.gypi index cd2fe52..7c1a57c 100644 --- a/components/history.gypi +++ b/components/history.gypi @@ -13,7 +13,6 @@ ], 'dependencies': [ '../base/base.gyp:base', - '../google_apis/google_apis.gyp:google_apis', '../net/net.gyp:net', '../skia/skia.gyp:skia', '../sql/sql.gyp:sql', @@ -25,7 +24,6 @@ 'history_core_browser_proto', 'keyed_service_core', 'query_parser', - 'signin_core_browser', ], 'sources': [ # Note: sources list duplicated in GN build. @@ -89,8 +87,6 @@ 'history/core/browser/visit_tracker.h', 'history/core/browser/visitsegment_database.cc', 'history/core/browser/visitsegment_database.h', - 'history/core/browser/web_history_service.cc', - 'history/core/browser/web_history_service.h', ], 'conditions': [ ['OS=="android"', { |