diff options
| author | rogerm <rogerm@chromium.org> | 2015-05-04 11:01:42 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-05-04 18:03:18 +0000 |
| commit | 9e748a2ffec614022292978e38be2dbafe0b154c (patch) | |
| tree | daf8e6f370049f664f81f8deb025d2785463b50a /components/history | |
| parent | a700384e6d64edb24f59af8168b0951c5082cbe2 (diff) | |
| download | chromium_src-9e748a2ffec614022292978e38be2dbafe0b154c.zip chromium_src-9e748a2ffec614022292978e38be2dbafe0b154c.tar.gz chromium_src-9e748a2ffec614022292978e38be2dbafe0b154c.tar.bz2 | |
Fix incorrect SQL binding in DB query for favicon metrics reporting.
The query for the number of touch and touch precomposed icons has two parameters, however both params are mistakenly bound to the slot 0.
BUG=484205
Review URL: https://codereview.chromium.org/1125733003
Cr-Commit-Position: refs/heads/master@{#328148}
Diffstat (limited to 'components/history')
| -rw-r--r-- | components/history/core/browser/thumbnail_database.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/components/history/core/browser/thumbnail_database.cc b/components/history/core/browser/thumbnail_database.cc index 7fc68d4..258a3b0 100644 --- a/components/history/core/browser/thumbnail_database.cc +++ b/components/history/core/browser/thumbnail_database.cc @@ -660,7 +660,7 @@ void ThumbnailDatabase::ComputeDatabaseMetrics() { SQL_FROM_HERE, "SELECT COUNT(*) FROM favicons WHERE icon_type IN (?, ?)")); touch_icon_count.BindInt64(0, favicon_base::TOUCH_ICON); - touch_icon_count.BindInt64(0, favicon_base::TOUCH_PRECOMPOSED_ICON); + touch_icon_count.BindInt64(1, favicon_base::TOUCH_PRECOMPOSED_ICON); UMA_HISTOGRAM_COUNTS_10000( "History.NumTouchIconsInDB", touch_icon_count.Step() ? touch_icon_count.ColumnInt(0) : 0); |