diff options
| author | jvoung@chromium.org <jvoung@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-11-06 22:45:04 +0000 |
|---|---|---|
| committer | jvoung@chromium.org <jvoung@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-11-06 22:45:04 +0000 |
| commit | 9c194eb99aeb9efd739b7e10c3cd9e067b84e6d8 (patch) | |
| tree | b2c4a4a0cd12109519dfb5652cdb148121d90430 /components/nacl.gyp | |
| parent | 1367bd6325642026ff6ac0a55a0f0e9fa9bda5ad (diff) | |
| download | chromium_src-9c194eb99aeb9efd739b7e10c3cd9e067b84e6d8.zip chromium_src-9c194eb99aeb9efd739b7e10c3cd9e067b84e6d8.tar.gz chromium_src-9c194eb99aeb9efd739b7e10c3cd9e067b84e6d8.tar.bz2 | |
Move most of TestNaClBrowserDelegate to another file.
It was originally in nacl_file_host_unittest.
Move it to components/ and consider it the "base" test
version. In nacl_file_host_unittest, provide slimmer version
that overrides just what we need for the unittest.
This means that we can reuse the TestNaClBrowserDelegate for
other tests. E.g., I'll be adding one for checking that
the "abi-version" matters for translation caching, and
to test that we need to do a similar trick of having a
Get/SetPnaclDirectory pair, so as not to modify the PNaCl
files inline.
It also means that we don't need to modify the test file
every time something is added to the NaClBrowserDelegate.
BUG=none
NOTRY=true
(already tried)
Review URL: https://codereview.chromium.org/51323004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233404 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'components/nacl.gyp')
| -rw-r--r-- | components/nacl.gyp | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/components/nacl.gyp b/components/nacl.gyp index 4eac816..3c0b26f 100644 --- a/components/nacl.gyp +++ b/components/nacl.gyp @@ -40,6 +40,7 @@ 'nacl/loader/nacl_validation_db.h', 'nacl/loader/nacl_validation_query.cc', 'nacl/loader/nacl_validation_query.h', + 'nacl/common/test_nacl_browser_delegate.cc', ], # TODO(gregoryd): consider switching NaCl to use Chrome OS defines 'conditions': [ |