summaryrefslogtreecommitdiffstats
path: root/components/page_load_metrics
diff options
context:
space:
mode:
authorcsharrison <csharrison@chromium.org>2015-10-01 13:51:18 -0700
committerCommit bot <commit-bot@chromium.org>2015-10-01 20:52:01 +0000
commit59f96948893a95b314c4284f2b880bc14fd50b55 (patch)
tree3adce40d6018b13515c55603cf5a3a94c6756472 /components/page_load_metrics
parentbdb73ec6019a7749391444a7db48615130648bf1 (diff)
downloadchromium_src-59f96948893a95b314c4284f2b880bc14fd50b55.zip
chromium_src-59f96948893a95b314c4284f2b880bc14fd50b55.tar.gz
chromium_src-59f96948893a95b314c4284f2b880bc14fd50b55.tar.bz2
Remove erroneous dcheck
Later we can see about re-adding it if load event semantics change. BUG=536203 Review URL: https://codereview.chromium.org/1382833003 Cr-Commit-Position: refs/heads/master@{#351881}
Diffstat (limited to 'components/page_load_metrics')
-rw-r--r--components/page_load_metrics/browser/metrics_web_contents_observer.cc14
1 files changed, 9 insertions, 5 deletions
diff --git a/components/page_load_metrics/browser/metrics_web_contents_observer.cc b/components/page_load_metrics/browser/metrics_web_contents_observer.cc
index fdde938..69ffa62 100644
--- a/components/page_load_metrics/browser/metrics_web_contents_observer.cc
+++ b/components/page_load_metrics/browser/metrics_web_contents_observer.cc
@@ -38,11 +38,15 @@ bool IsValidPageLoadTiming(const PageLoadTiming& timing) {
timing.response_start <= timing.dom_content_loaded_event_start);
// If we have a load event, we should have both a response start and a DCL.
- DCHECK_IMPLIES(
- !timing.load_event_start.is_zero(),
- !timing.dom_content_loaded_event_start.is_zero() &&
- timing.response_start <= timing.load_event_start &&
- timing.dom_content_loaded_event_start <= timing.load_event_start);
+ // TODO(csharrison) crbug.com/536203 shows that sometimes we can get a load
+ // event without a DCL. Figure out if we can change this condition to use a
+ // DCHECK instead.
+ if (!timing.load_event_start.is_zero() &&
+ (timing.dom_content_loaded_event_start.is_zero() ||
+ timing.response_start > timing.load_event_start ||
+ timing.dom_content_loaded_event_start > timing.load_event_start)) {
+ return false;
+ }
return true;
}