summaryrefslogtreecommitdiffstats
path: root/components/signin
diff options
context:
space:
mode:
authorcaseq <caseq@chromium.org>2014-12-12 11:00:39 -0800
committerCommit bot <commit-bot@chromium.org>2014-12-12 19:01:00 +0000
commit5262e5a158f6302eb4dac49d416b1a00f37186ba (patch)
tree684ea826d80947940ddc55a3494032388fefc71d /components/signin
parentce39d41c13db11a69564ba2299f7e83d3fa05c3c (diff)
downloadchromium_src-5262e5a158f6302eb4dac49d416b1a00f37186ba.zip
chromium_src-5262e5a158f6302eb4dac49d416b1a00f37186ba.tar.gz
chromium_src-5262e5a158f6302eb4dac49d416b1a00f37186ba.tar.bz2
Tracing: make filtering logic more intuitive for multiple categories
This changes the way category filter processes multi-categories groups. Previously, adding a disabled-by-default- category to a regular category would prevent the event from matching filter if only regular category is enabled. This is somewhat counter-intuitive, the expected behavior is that each category is processed by the filter independently. The new logic is: 1. if at least one category in event category group matches at least one category enabled in the filter, the event passes; 2. if at least one category in event category group matches at least one category explicitly excluded in the filter, the event is filtered out; 3. the event is passed by default, if included categories list is empty and event has at least one category that is not disabled-by-default-. Note no existing tests were modified (though I'm not sure if (2) should be the way it is). BUG= Review URL: https://codereview.chromium.org/788243003 Cr-Commit-Position: refs/heads/master@{#308136}
Diffstat (limited to 'components/signin')
0 files changed, 0 insertions, 0 deletions