diff options
author | rogerta <rogerta@chromium.org> | 2015-12-16 19:24:45 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-12-17 03:26:34 +0000 |
commit | 5f5bb820bb248b8ba47a53d60aefb85ca19ffb80 (patch) | |
tree | 8dddb17fd7c961cf9713cf77a8cc319cc2d10ca8 /components/signin | |
parent | a590fefdefb1002bdeb4673fab4e88017cc3b211 (diff) | |
download | chromium_src-5f5bb820bb248b8ba47a53d60aefb85ca19ffb80.zip chromium_src-5f5bb820bb248b8ba47a53d60aefb85ca19ffb80.tar.gz chromium_src-5f5bb820bb248b8ba47a53d60aefb85ca19ffb80.tar.bz2 |
Remove enable-iframe-based-signin flag. This affects only desktop chrome. Users can no longer use the deprecated iframe based sign in flow. This flow has been deprecated since m41.
This CL removes the code to get partitions ids and support for page zooming for the old iframe sign in flow.
BUG=493846
Review URL: https://codereview.chromium.org/1412453002
Cr-Commit-Position: refs/heads/master@{#365712}
Diffstat (limited to 'components/signin')
5 files changed, 0 insertions, 20 deletions
diff --git a/components/signin/core/browser/about_signin_internals.cc b/components/signin/core/browser/about_signin_internals.cc index 4bec52f..a144f84 100644 --- a/components/signin/core/browser/about_signin_internals.cc +++ b/components/signin/core/browser/about_signin_internals.cc @@ -516,8 +516,6 @@ scoped_ptr<base::DictionaryValue> AboutSigninInternals::SigninStatus::ToValue( // A summary of signin related info first. base::ListValue* basic_info = AddSection(signin_info, "Basic Information"); AddSectionEntry(basic_info, "Chrome Version", product_version); - AddSectionEntry(basic_info, "Webview Based Signin?", - switches::IsEnableWebviewBasedSignin() == true ? "On" : "Off"); AddSectionEntry(basic_info, "New Profile Management?", switches::IsNewProfileManagement() == true ? "On" : "Off"); AddSectionEntry(basic_info, "Account Consistency?", diff --git a/components/signin/core/common/profile_management_switches.cc b/components/signin/core/common/profile_management_switches.cc index 42e78b4..7c103b7 100644 --- a/components/signin/core/common/profile_management_switches.cc +++ b/components/signin/core/common/profile_management_switches.cc @@ -110,16 +110,6 @@ bool IsEnableAccountConsistency() { return GetProcessState() >= STATE_ACCOUNT_CONSISTENCY; } -bool IsEnableWebviewBasedSignin() { - // For now, the webview is enabled only for desktop. -#if defined(OS_CHROMEOS) - return false; -#else - return !base::CommandLine::ForCurrentProcess()->HasSwitch( - switches::kEnableIframeBasedSignin); -#endif -} - bool IsExtensionsMultiAccount() { return CheckFlag(switches::kExtensionsMultiAccount, STATE_ACCOUNT_CONSISTENCY); diff --git a/components/signin/core/common/profile_management_switches.h b/components/signin/core/common/profile_management_switches.h index f6b2190..2b60446 100644 --- a/components/signin/core/common/profile_management_switches.h +++ b/components/signin/core/common/profile_management_switches.h @@ -19,9 +19,6 @@ namespace switches { // management UI is available in the avatar bubble. bool IsEnableAccountConsistency(); -// Checks whether the webview-based sign in flow is enabled on Chrome desktop. -bool IsEnableWebviewBasedSignin(); - // Whether the chrome.identity API should be multi-account. bool IsExtensionsMultiAccount(); diff --git a/components/signin/core/common/signin_switches.cc b/components/signin/core/common/signin_switches.cc index 88647c8..9b97b46 100644 --- a/components/signin/core/common/signin_switches.cc +++ b/components/signin/core/common/signin_switches.cc @@ -26,10 +26,6 @@ const char kDisableSigninScopedDeviceId[] = "disable-signin-scoped-device-id"; // Enables consistent identity features. const char kEnableAccountConsistency[] = "enable-account-consistency"; -// Enables the old iframe-based flow for sign in. When not enabled, uses the -// webview-based flow. -const char kEnableIframeBasedSignin[] = "enable-iframe-based-signin"; - // Enables new gaia password-separated sign in flow. const char kEnablePasswordSeparatedSigninFlow[] = "enable-password-separated-signin-flow"; diff --git a/components/signin/core/common/signin_switches.h b/components/signin/core/common/signin_switches.h index 68a03b0..ec9c7a6 100644 --- a/components/signin/core/common/signin_switches.h +++ b/components/signin/core/common/signin_switches.h @@ -19,7 +19,6 @@ extern const char kDisablePasswordSeparatedSigninFlow[]; extern const char kDisableNewProfileManagement[]; extern const char kDisableSigninScopedDeviceId[]; extern const char kEnableAccountConsistency[]; -extern const char kEnableIframeBasedSignin[]; extern const char kEnablePasswordSeparatedSigninFlow[]; extern const char kEnableNewProfileManagement[]; extern const char kEnableRefreshTokenAnnotationRequest[]; |