diff options
author | kuan@chromium.org <kuan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-16 20:04:08 +0000 |
---|---|---|
committer | kuan@chromium.org <kuan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-16 20:04:08 +0000 |
commit | 863b3b16bdac92ec0e950338cd5c2c5b825eede1 (patch) | |
tree | 8117670e3679b07e7c2e9b6d54412743c0fe00d0 /components/sync_driver/sync_frontend.h | |
parent | 3f0825071b06ecb5bae3f87da801b5e03589694c (diff) | |
download | chromium_src-863b3b16bdac92ec0e950338cd5c2c5b825eede1.zip chromium_src-863b3b16bdac92ec0e950338cd5c2c5b825eede1.tar.gz chromium_src-863b3b16bdac92ec0e950338cd5c2c5b825eede1.tar.bz2 |
Revert of Sync: Refactoring of DEVICE_INFO syncable type - Part 1 (https://codereview.chromium.org/367153005/)
Reason for revert:
this broke unit_tests" on "Linux ASan LSan Tests (2):
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/4967.
Original issue's description:
> Sync: Refactoring of DEVICE_INFO syncable type - Part 1
>
> This change introduces a new class LocalDeviceInfoProvider that is responsible
> for providing the local device specific DeviceInfo/cache_guid. It initializes
> the data asynchronously and allows consumers to get notified when the data
> becomes available.
>
> LocalDeviceInfoProvider will allow to remove these responsibilities from
> SyncedDeviceTracker / ProfileSyncService and loose coupling between
> ProfileSyncService and a number of SyncableService and DataTypeController
> derived classes.
>
> LocalDeviceInfoProvider is hosted on the frontend thread. Since it needs
> cache_guid to initialize DeviceInfo, which is currently available only on the
> backend, I updated SyncBackendHostCore and SyncBackendHostImpl to pass
> cache_guid to the frontend via OnBackendInitialized.
>
> For the time being SyncedDeviceTracker remains unchanged
> and continues to initialize the local device info too. The entire class will be
> removed in the Part 2 of the change which will move SyncedDeviceTracker
> functionality to a new SyncableService.
>
> LocalDeviceInfoProvider also replaces SessionsSyncManager::SyncInternalApiDelegate
> which was previously used to decouple SessionsSyncManager from the specifics of
> of the local device info implementation.
> SessionsSyncManager is changed to consume LocalDeviceInfoProvider instead of
> SessionsSyncManager::SyncInternalApiDelegate.
> SessionDataTypeController now also consumes LocalDeviceInfoProvider to make sure
> that SESSIONS type model doesn't start before local device info becomes available.
> A very similar approach will be used in the upcoming second part of the change
> for DEVICE_INFO DataTypeController and SyncableType.
>
> The change includes new unit tests for LocalDeviceInfoProvider and
> SessionDataTypeController.
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283461
TBR=zea@chromium.org,rlarocque@chromium.org,sky@chromium.org,maniscalco@chromium.org,stanisc@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/401433003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283475 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'components/sync_driver/sync_frontend.h')
-rw-r--r-- | components/sync_driver/sync_frontend.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/components/sync_driver/sync_frontend.h b/components/sync_driver/sync_frontend.h index 247d215..0a360a8 100644 --- a/components/sync_driver/sync_frontend.h +++ b/components/sync_driver/sync_frontend.h @@ -48,7 +48,6 @@ class SyncFrontend { const syncer::WeakHandle<syncer::JsBackend>& js_backend, const syncer::WeakHandle<syncer::DataTypeDebugInfoListener>& debug_info_listener, - const std::string& cache_guid, bool success) = 0; // The backend queried the server recently and received some updates. |