diff options
| author | wittman <wittman@chromium.org> | 2015-03-17 14:14:46 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-03-17 21:15:39 +0000 |
| commit | c8ae1d65bada9e45e2fcfa4a00f0f18018e823bb (patch) | |
| tree | b77e450d0c7aed9a973ead75dd277fb673586c2a /components/sync_driver | |
| parent | bba16e7a9323bca8d411ff5f51a94093d889df2b (diff) | |
| download | chromium_src-c8ae1d65bada9e45e2fcfa4a00f0f18018e823bb.zip chromium_src-c8ae1d65bada9e45e2fcfa4a00f0f18018e823bb.tar.gz chromium_src-c8ae1d65bada9e45e2fcfa4a00f0f18018e823bb.tar.bz2 | |
Remove enhanced bookmarks sync experiment
Uses the enhanced bookmarks Finch experiment as the only mechanism for
enabling enhanced bookmarks in Chrome. With this change we no longer
need the EnhancedBookmarks.SyncExperimentState UMA histogram since we
can now get all the relevant metrics via Finch.
BUG=467040
Review URL: https://codereview.chromium.org/1009673002
Cr-Commit-Position: refs/heads/master@{#320973}
Diffstat (limited to 'components/sync_driver')
| -rw-r--r-- | components/sync_driver/pref_names.cc | 6 | ||||
| -rw-r--r-- | components/sync_driver/pref_names.h | 3 | ||||
| -rw-r--r-- | components/sync_driver/sync_prefs.cc | 11 |
3 files changed, 0 insertions, 20 deletions
diff --git a/components/sync_driver/pref_names.cc b/components/sync_driver/pref_names.cc index 6ce6585..9ba8dda 100644 --- a/components/sync_driver/pref_names.cc +++ b/components/sync_driver/pref_names.cc @@ -8,12 +8,6 @@ namespace sync_driver { namespace prefs { -// Set to true when enhanced bookmarks experiment is enabled via Chrome sync. -const char kEnhancedBookmarksExperimentEnabled[] = "enhanced_bookmarks_enabled"; - -// Enhanced bookmarks extension id passed via Chrome sync. -const char kEnhancedBookmarksExtensionId[] = "enhanced_bookmarks_extension_id"; - // 64-bit integer serialization of the base::Time when the last sync occurred. const char kSyncLastSyncedTime[] = "sync.last_synced_time"; diff --git a/components/sync_driver/pref_names.h b/components/sync_driver/pref_names.h index 5eb8578..425fb41 100644 --- a/components/sync_driver/pref_names.h +++ b/components/sync_driver/pref_names.h @@ -10,9 +10,6 @@ namespace sync_driver { namespace prefs { -extern const char kEnhancedBookmarksExperimentEnabled[]; -extern const char kEnhancedBookmarksExtensionId[]; - extern const char kSyncLastSyncedTime[]; extern const char kSyncHasAuthError[]; extern const char kSyncHasSetupCompleted[]; diff --git a/components/sync_driver/sync_prefs.cc b/components/sync_driver/sync_prefs.cc index c1c228ac..4f1b27f 100644 --- a/components/sync_driver/sync_prefs.cc +++ b/components/sync_driver/sync_prefs.cc @@ -72,17 +72,6 @@ void SyncPrefs::RegisterProfilePrefs( user_types.Remove(syncer::BOOKMARKS); user_types.Remove(syncer::DEVICE_INFO); - // These two prefs are set from sync experiment to enable enhanced bookmarks. - registry->RegisterIntegerPref( - prefs::kEnhancedBookmarksExperimentEnabled, - 0, - user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF); - - registry->RegisterStringPref( - prefs::kEnhancedBookmarksExtensionId, - std::string(), - user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF); - // All types are set to off by default, which forces a configuration to // explicitly enable them. GetPreferredTypes() will ensure that any new // implicit types are enabled when their pref group is, or via |