diff options
| author | sdefresne <sdefresne@chromium.org> | 2016-01-15 07:39:08 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-01-15 15:40:06 +0000 |
| commit | 395b039719c3594151d18bfd4231048353c1564b (patch) | |
| tree | b607518bd0919d9d7d624f40316896b4ad19e0b9 /components/translate_strings.grdp | |
| parent | e923740b2b3b65dffe86ecce49579f9121396ab0 (diff) | |
| download | chromium_src-395b039719c3594151d18bfd4231048353c1564b.zip chromium_src-395b039719c3594151d18bfd4231048353c1564b.tar.gz chromium_src-395b039719c3594151d18bfd4231048353c1564b.tar.bz2 | |
Fix placeholder numbering in iOS specific strings.
The string IDS_TRANSLATE_INFOBAR_NEVER_MESSAGE_IOS only used a single
placeholder but used "$2" instead of "$1" causing a DCHECK. Use the
correct value.
Rename the constant IDS_IOS_TRANSLATE_INFOBAR_NEVER_MESSAGE and move
the string to ios/chrome/app/ios_${branding}_strings.grd as it is
only used on iOS.
BUG=None
Review URL: https://codereview.chromium.org/1585923007
Cr-Commit-Position: refs/heads/master@{#369751}
Diffstat (limited to 'components/translate_strings.grdp')
| -rw-r--r-- | components/translate_strings.grdp | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/components/translate_strings.grdp b/components/translate_strings.grdp index fb8caeb..b4de758 100644 --- a/components/translate_strings.grdp +++ b/components/translate_strings.grdp @@ -42,18 +42,6 @@ <message name="IDS_TRANSLATE_INFOBAR_NEVER_TRANSLATE" desc="Button label shown to never translate a specific language in the translate infobar"> Never translate <ph name="language">$1<ex>French</ex></ph> </message> - <if expr="is_ios"> - <if expr="_google_chrome"> - <message name="IDS_TRANSLATE_INFOBAR_NEVER_MESSAGE_IOS" desc="Message for the Translate infobar to allow the user to opt out. [Length: 250em] [iOS only]"> - Would you like Google Chrome to offer to translate <ph name="LANGUAGE_NAME">$2<ex>French</ex></ph> pages from this site next time? - </message> - </if> - <if expr="not _google_chrome"> - <message name="IDS_TRANSLATE_INFOBAR_NEVER_MESSAGE_IOS" desc="Message for the Translate infobar to allow the user to opt out. [Length: 250em] [iOS only]"> - Would you like Chromium to offer to translate <ph name="LANGUAGE_NAME">$2<ex>French</ex></ph> pages from this site next time? - </message> - </if> - </if> <message name="IDS_TRANSLATE_INFOBAR_ALWAYS_TRANSLATE" desc="Button label shown to always translate a specific language in the translate infobar"> Always translate <ph name="language">$1<ex>English</ex></ph> </message> |