Fix destruction order of PromoResourceService and NTPResourceCache

The existing code was leading to a crash:
- NTPResourceCache has a callback subscription on PromoResourceService
- PromoResourceService was deleted before NTPResourceCache
- When the NTPResourceCache was destroyed, it tried to remove itself
  from the callback list, which no longer exists and crashes.

The bug was introduced by
https://codereview.chromium.org/926633002

This CL changes the destruction order so that the PromoResourceService
is deleted after NTPResourceCache (which is a keyed service and thus is
tied to the profile).

BUG=464391

Review URL: https://codereview.chromium.org/988433002

Cr-Commit-Position: refs/heads/master@{#319491}

1 files changed, 1 insertions, 1 deletions

diff --git a/components/update_client/update_query_params.cc b/components/update_client/update_query_params.cc
index 7bb4db5..33bd00e 100644
--- a/components/update_client/update_query_params.cc
+++ b/components/update_client/update_query_params.cc
@@ -124,7 +124,7 @@ const char* UpdateQueryParams::GetNaclArch() {
 
 // static
 void UpdateQueryParams::SetDelegate(UpdateQueryParamsDelegate* delegate) {
-  DCHECK(!g_delegate || !delegate);
+  DCHECK(!g_delegate || !delegate || (delegate == g_delegate));
   g_delegate = delegate;
 }