diff options
| author | rsleevi@chromium.org <rsleevi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-11 16:46:36 +0000 |
|---|---|---|
| committer | rsleevi@chromium.org <rsleevi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-11 16:46:36 +0000 |
| commit | cadac62e5c2b9f5fef59ce0326bb2cd79ffbe622 (patch) | |
| tree | 7b95f103fce509de887c8c5e643604855b57c0ba /components/webdata/common | |
| parent | 9f6e673c7f43f6ee414f72a74585dad8ebaceec3 (diff) | |
| download | chromium_src-cadac62e5c2b9f5fef59ce0326bb2cd79ffbe622.zip chromium_src-cadac62e5c2b9f5fef59ce0326bb2cd79ffbe622.tar.gz chromium_src-cadac62e5c2b9f5fef59ce0326bb2cd79ffbe622.tar.bz2 | |
Call scoped_refptr<T>::get() rather than relying on implicit "operator T*"
This upates calls to bound temporary objects to also use get().
While it has the same semantic equivalence to the existing code, this generally
represents a dangerous pattern - indeed, part of the whole motivation for this
change is to make this anti-pattern very visible to authors.
This change simply updates all of the call sites, to allow the "operator T*"
to be removed and preventing new instances. The existing instances will then be
reviewed for "suspicious" changes and updated to use/pass scoped_refptr<T>
rather than T*, as appropriate.
BUG=110610
TBR=darin
Review URL: https://codereview.chromium.org/15984016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205560 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'components/webdata/common')
| -rw-r--r-- | components/webdata/common/web_data_service_base.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/components/webdata/common/web_data_service_base.cc b/components/webdata/common/web_data_service_base.cc index e05da38..6422cb4 100644 --- a/components/webdata/common/web_data_service_base.cc +++ b/components/webdata/common/web_data_service_base.cc @@ -61,14 +61,14 @@ void WebDataServiceBase::CancelRequest(Handle h) { } bool WebDataServiceBase::IsDatabaseLoaded() { - if (!wdbs_) + if (!wdbs_.get()) return false; return wdbs_->db_loaded(); } void WebDataServiceBase::RegisterDBLoadedCallback( const base::Callback<void(void)>& callback) { - if (!wdbs_) + if (!wdbs_.get()) return; wdbs_->RegisterDBLoadedCallback(callback); } |