diff options
| author | dtu@chromium.org <dtu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-05-16 19:01:52 +0000 |
|---|---|---|
| committer | dtu@chromium.org <dtu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-05-16 19:01:52 +0000 |
| commit | 58253ed45cf9f45828d380ceab10872e7ca2a08d (patch) | |
| tree | 454b2299fa648fca835e9459344388f3a7d15a6a /components | |
| parent | 9eba0d1ab119107b390402c371b04af9cde0d23c (diff) | |
| download | chromium_src-58253ed45cf9f45828d380ceab10872e7ca2a08d.zip chromium_src-58253ed45cf9f45828d380ceab10872e7ca2a08d.tar.gz chromium_src-58253ed45cf9f45828d380ceab10872e7ca2a08d.tar.bz2 | |
Make PageTestResults inherit from unittest.TestResult and follow its interface.
Now GTestTestResults (and future TestResults) can get both PageTest and unittest support by implementing just the unittest methods.
Interface changes:
errors are distinguished from failures. failures are only used when the test throws a page_test.Failure (as in, the test itself failed) All crashes, missing WPR, etc. are errors.
AddError()/AddFailure() now take an exception info tuple instead of a message. To compensate we have AddErrorMessage()/AddFailureMessage().
Reduced exception handling in PageRunner. We were catching a lot of cases and treating each one slightly differently, probably because no one really knows how they should be treated.
results.successes is now a list of URLs instead of pages. results.failures is now a list of (URL, message) tuples, similar to unittest.
BUG=239323
TEST=./run_tests
R=nduca@chromium.org, tonyg@chromium.org
Review URL: https://codereview.chromium.org/15153003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200596 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'components')
0 files changed, 0 insertions, 0 deletions