diff options
author | hajimehoshi@chromium.org <hajimehoshi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-31 09:19:01 +0000 |
---|---|---|
committer | hajimehoshi@chromium.org <hajimehoshi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-31 09:19:01 +0000 |
commit | 3e1c839692ddfe2fcb70b7ebd97305b89ea0fc78 (patch) | |
tree | f575a1e3cf1f59954081fbde8f7432acc4cdd4e0 /components | |
parent | fb449a8716172a45e78ec3f38e592065a1e1be4a (diff) | |
download | chromium_src-3e1c839692ddfe2fcb70b7ebd97305b89ea0fc78.zip chromium_src-3e1c839692ddfe2fcb70b7ebd97305b89ea0fc78.tar.gz chromium_src-3e1c839692ddfe2fcb70b7ebd97305b89ea0fc78.tar.bz2 |
Collect UMAs (Modify*Lang) into TranslateUIDelegate
Renamed TranslateUIDelegate::Set*LanguageIndex to Update*LanguageIndex and have them include UMA callings.
BUG=312720
TEST=unit_tests --gtest_filter=TranslateBubbleViewTest.*
Review URL: https://codereview.chromium.org/52213002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232057 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'components')
-rw-r--r-- | components/translate/common/translate_metrics.cc | 9 | ||||
-rw-r--r-- | components/translate/common/translate_metrics.h | 2 |
2 files changed, 1 insertions, 10 deletions
diff --git a/components/translate/common/translate_metrics.cc b/components/translate/common/translate_metrics.cc index 5402491..b095084 100644 --- a/components/translate/common/translate_metrics.cc +++ b/components/translate/common/translate_metrics.cc @@ -23,9 +23,6 @@ const char kTranslateTimeToTranslate[] = "Translate.TimeToTranslate"; const char kTranslateUserActionDuration[] = "Translate.UserActionDuration"; const char kTranslatePageScheme[] = "Translate.PageScheme"; const char kTranslateSimilarLanguageMatch[] = "Translate.SimilarLanguageMatch"; -const char kTranslateModifyOriginalLang[] = "Translate.ModifyOriginalLang"; -const char kTranslateModifyTargetLang[] = "Translate.ModifyTargetlLang"; - const char kSchemeHttp[] = "http"; const char kSchemeHttps[] = "https"; @@ -36,8 +33,6 @@ struct MetricsEntry { }; // This entry table should be updated when new UMA items are added. -// TODO(miguelg) Move kTranslateModifyOriginalLang and -// kTranslateModifyTargetLang to the UX delegate once crbug/312720 is fixed. const MetricsEntry kMetricsEntries[] = { {UMA_LANGUAGE_DETECTION, kRenderer4LanguageDetection}, {UMA_CONTENT_LANGUAGE, kTranslateContentLanguage}, @@ -48,9 +43,7 @@ const MetricsEntry kMetricsEntries[] = { {UMA_TIME_TO_TRANSLATE, kTranslateTimeToTranslate}, {UMA_USER_ACTION_DURATION, kTranslateUserActionDuration}, {UMA_PAGE_SCHEME, kTranslatePageScheme}, - {UMA_SIMILAR_LANGUAGE_MATCH, kTranslateSimilarLanguageMatch}, - {UMA_MODIFY_ORIGINAL_LANG, kTranslateModifyOriginalLang}, - {UMA_MODIFY_TARGET_LANG, kTranslateModifyTargetLang}, }; + {UMA_SIMILAR_LANGUAGE_MATCH, kTranslateSimilarLanguageMatch}, }; COMPILE_ASSERT(arraysize(kMetricsEntries) == UMA_MAX, arraysize_of_kMetricsEntries_should_be_UMA_MAX); diff --git a/components/translate/common/translate_metrics.h b/components/translate/common/translate_metrics.h index a38db44..9baa268 100644 --- a/components/translate/common/translate_metrics.h +++ b/components/translate/common/translate_metrics.h @@ -24,8 +24,6 @@ enum MetricsNameIndex { UMA_USER_ACTION_DURATION, UMA_PAGE_SCHEME, UMA_SIMILAR_LANGUAGE_MATCH, - UMA_MODIFY_ORIGINAL_LANG, - UMA_MODIFY_TARGET_LANG, UMA_MAX, }; |