diff options
| author | csharp@chromium.org <csharp@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-07-26 10:55:55 +0000 |
|---|---|---|
| committer | csharp@chromium.org <csharp@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-07-26 10:55:55 +0000 |
| commit | 229d14917ab633812576227bb6b0436a73f27623 (patch) | |
| tree | c41846588be68bceb068804d6bc1d35a9db4f27f /components | |
| parent | bb4b8b798925d91b8d0493fee6d1fba189477278 (diff) | |
| download | chromium_src-229d14917ab633812576227bb6b0436a73f27623.zip chromium_src-229d14917ab633812576227bb6b0436a73f27623.tar.gz chromium_src-229d14917ab633812576227bb6b0436a73f27623.tar.bz2 | |
[Autofill] Investigate Autofill Flakiness
Add additional logging to try and track down source of flakiness.
BUG=150084
Review URL: https://chromiumcodereview.appspot.com/19818008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213832 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'components')
| -rw-r--r-- | components/autofill/content/renderer/autofill_agent.cc | 6 | ||||
| -rw-r--r-- | components/autofill/core/browser/autofill_external_delegate.cc | 6 |
2 files changed, 12 insertions, 0 deletions
diff --git a/components/autofill/content/renderer/autofill_agent.cc b/components/autofill/content/renderer/autofill_agent.cc index f61902f..ff534bd 100644 --- a/components/autofill/content/renderer/autofill_agent.cc +++ b/components/autofill/content/renderer/autofill_agent.cc @@ -627,6 +627,9 @@ void AutofillAgent::ShowSuggestions(const WebInputElement& element, bool autofill_on_empty_values, bool requires_caret_at_end, bool display_warning_if_disabled) { + // TODO(csharp): Remove once Autofill test flakiness is fixed. + LOG(INFO) << "AutofillAgent::ShowSuggestions"; + if (!element.isEnabled() || element.isReadOnly() || !element.isTextField() || element.isPasswordField() || !element.suggestedValue().isEmpty()) return; @@ -663,6 +666,9 @@ void AutofillAgent::ShowSuggestions(const WebInputElement& element, void AutofillAgent::QueryAutofillSuggestions(const WebInputElement& element, bool display_warning_if_disabled) { + // TODO(csharp): Remove once Autofill test flakiness is fixed. + LOG(INFO) << "AutofillAgent::QueryAutofillSuggestions"; + if (!element.document().frame()) return; diff --git a/components/autofill/core/browser/autofill_external_delegate.cc b/components/autofill/core/browser/autofill_external_delegate.cc index 95119bf..1cf7c06 100644 --- a/components/autofill/core/browser/autofill_external_delegate.cc +++ b/components/autofill/core/browser/autofill_external_delegate.cc @@ -48,6 +48,9 @@ void AutofillExternalDelegate::OnQuery(int query_id, const FormFieldData& field, const gfx::RectF& element_bounds, bool display_warning_if_disabled) { + // TODO(csharp): Remove once Autofill test flakiness is fixed. + LOG(INFO) << "AutofillExternalDelegate::OnQuery"; + autofill_query_form_ = form; autofill_query_field_ = field; display_warning_if_disabled_ = display_warning_if_disabled; @@ -61,6 +64,9 @@ void AutofillExternalDelegate::OnSuggestionsReturned( const std::vector<base::string16>& autofill_labels, const std::vector<base::string16>& autofill_icons, const std::vector<int>& autofill_unique_ids) { + // TODO(csharp): Remove once Autofill test flakiness is fixed. + LOG(INFO) << "AutofillExternalDelegate::OnSuggestionsReturned"; + if (query_id != autofill_query_id_) return; |