diff options
author | megjablon <megjablon@chromium.org> | 2014-09-19 19:26:44 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-09-20 02:26:58 +0000 |
commit | 3d6e847d28e399f4ae8cd879c7df1a3b3baa1e52 (patch) | |
tree | 3524d6f105beb88a860b5d82f0f6e15fd84a16bc /components | |
parent | a5171187b34bab562cc357196593310f9be41551 (diff) | |
download | chromium_src-3d6e847d28e399f4ae8cd879c7df1a3b3baa1e52.zip chromium_src-3d6e847d28e399f4ae8cd879c7df1a3b3baa1e52.tar.gz chromium_src-3d6e847d28e399f4ae8cd879c7df1a3b3baa1e52.tar.bz2 |
DataReductionProxy.BypassedBytes.* counts all triggering request bytes
All DataReductionProxy.BypassedBytes.* UMA that don't have an explicit triggering
request UMA need to count the triggering request bytes.
BUG=413771
Review URL: https://codereview.chromium.org/566943004
Cr-Commit-Position: refs/heads/master@{#295848}
Diffstat (limited to 'components')
-rw-r--r-- | components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.cc | 29 |
1 files changed, 17 insertions, 12 deletions
diff --git a/components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.cc b/components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.cc index b240947..6a35460 100644 --- a/components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.cc +++ b/components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.cc @@ -198,15 +198,20 @@ void DataReductionProxyUsageStats::RecordBypassedBytesHistograms( return; } - if (triggering_request_) { - // We only record when audio or video triggers a bypass. We don't care - // about audio and video bypassed as collateral damage. + // Only record separate triggering request UMA for short, medium, and long + // bypass events. + if (triggering_request_ && + (last_bypass_type_ == BYPASS_EVENT_TYPE_SHORT || + last_bypass_type_ == BYPASS_EVENT_TYPE_MEDIUM || + last_bypass_type_ == BYPASS_EVENT_TYPE_LONG)) { std::string mime_type; request.GetMimeType(&mime_type); - // MIME types are named by <media-type>/<subtype>. We check to see if the - // media type is audio or video. - if (mime_type.compare(0, 6, "audio/") == 0 || - mime_type.compare(0, 6, "video/") == 0) { + // MIME types are named by <media-type>/<subtype>. Check to see if the + // media type is audio or video. Only record when triggered by short bypass, + // there isn't an audio or video bucket for medium or long bypasses. + if (last_bypass_type_ == BYPASS_EVENT_TYPE_SHORT && + (mime_type.compare(0, 6, "audio/") == 0 || + mime_type.compare(0, 6, "video/") == 0)) { RecordBypassedBytes(last_bypass_type_, DataReductionProxyUsageStats::AUDIO_VIDEO, content_length); @@ -227,11 +232,11 @@ void DataReductionProxyUsageStats::RecordBypassedBytesHistograms( return; } - if (data_reduction_proxy_params_-> - AreDataReductionProxiesBypassed(request, NULL)) { - RecordBypassedBytes(last_bypass_type_, - DataReductionProxyUsageStats::NETWORK_ERROR, - content_length); + if (data_reduction_proxy_params_->AreDataReductionProxiesBypassed(request, + NULL)) { + RecordBypassedBytes(last_bypass_type_, + DataReductionProxyUsageStats::NETWORK_ERROR, + content_length); } } |