diff options
author | tfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-30 00:38:20 +0000 |
---|---|---|
committer | tfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-30 00:38:20 +0000 |
commit | 803b2edd16b3a997429dc1444a0c8494a4f7c94f (patch) | |
tree | e2ddffab2479d2d7db9cbe45f8b4676d6464ab64 /components | |
parent | e271ad6e5ffe52a9717f246150dc6bfb90728596 (diff) | |
download | chromium_src-803b2edd16b3a997429dc1444a0c8494a4f7c94f.zip chromium_src-803b2edd16b3a997429dc1444a0c8494a4f7c94f.tar.gz chromium_src-803b2edd16b3a997429dc1444a0c8494a4f7c94f.tar.bz2 |
components: Fix a couple of the TODO(GYP) todos.
BUG=None
TEST=gn gen out/Debug_gn + build the effected targets with ninja.
R=brettw@chromium.org
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/420113003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286362 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'components')
-rw-r--r-- | components/autofill/content/browser/BUILD.gn | 2 | ||||
-rw-r--r-- | components/autofill/core/browser/BUILD.gn | 4 | ||||
-rw-r--r-- | components/invalidation/BUILD.gn | 9 | ||||
-rw-r--r-- | components/policy/core/browser/BUILD.gn | 2 | ||||
-rw-r--r-- | components/search_engines/BUILD.gn | 2 |
5 files changed, 9 insertions, 10 deletions
diff --git a/components/autofill/content/browser/BUILD.gn b/components/autofill/content/browser/BUILD.gn index dce931d..e68a525 100644 --- a/components/autofill/content/browser/BUILD.gn +++ b/components/autofill/content/browser/BUILD.gn @@ -48,6 +48,7 @@ static_library("browser") { "//components/os_crypt", "//components/resources", "//components/strings", + "//components/user_prefs", "//components/webdata/common", "//content/public/browser", "//content/public/common", @@ -62,7 +63,6 @@ static_library("browser") { "//ui/gfx/geometry", "//url", #"../third_party/libjingle/libjingle.gyp:libjingle", TODO(GYP) - #"user_prefs", TODO(GYP) ] forward_dependent_configs_from = [ diff --git a/components/autofill/core/browser/BUILD.gn b/components/autofill/core/browser/BUILD.gn index 6304488..9f3713c 100644 --- a/components/autofill/core/browser/BUILD.gn +++ b/components/autofill/core/browser/BUILD.gn @@ -138,12 +138,14 @@ static_library("browser") { "//components/autofill/core/common", "//components/keyed_service/core", "//components/os_crypt", + "//components/pref_registry", "//components/resources", "//components/strings", "//components/webdata/common", "//google_apis", "//skia", "//sql", + "//third_party/fips181", "//third_party/icu", "//third_party/libaddressinput:util", "//third_party/libphonenumber", @@ -151,10 +153,8 @@ static_library("browser") { "//ui/gfx", "//ui/gfx/geometry", "//url", - #'../third_party/fips181/fips181.gyp:fips181', TODO(GYP) # TODO(GYP) also remove libjingle_stub_config below when this is added: #'../third_party/libjingle/libjingle.gyp:libjingle', TODO(GYP) - #'pref_registry', TODO(GYP) ] configs += [ "//content:libjingle_stub_config" ] diff --git a/components/invalidation/BUILD.gn b/components/invalidation/BUILD.gn index fd6773a..078ad64 100644 --- a/components/invalidation/BUILD.gn +++ b/components/invalidation/BUILD.gn @@ -81,12 +81,11 @@ static_library("invalidation") { deps = [ "//base", - #"//components/gcm_driver", TODO(GYP) - "//google_apis", + "//components/gcm_driver", "//components/keyed_service/core", - "//components/signin/core/browser:browser", "//components/pref_registry", - #"//components/signin/core/browser", TODO(GYP) + "//components/signin/core/browser", + "//google_apis", "//sync", "//third_party/cacheinvalidation", #'../jingle/jingle.gyp:notifier', TODO(GYP) @@ -124,6 +123,7 @@ static_library("test_support") { deps = [ "//base", + "//components/gcm_driver:test_support", "//components/keyed_service/core", "//google_apis", "//net", @@ -133,6 +133,5 @@ static_library("test_support") { #'../jingle/jingle.gyp:notifier', TODO(GYP) #'../jingle/jingle.gyp:notifier_test_util', TODO(GYP) #'../sync/sync.gyp:test_support_sync_notifier', TODO(GYP) - #'gcm_driver_test_support', TODO(GYP) ] } diff --git a/components/policy/core/browser/BUILD.gn b/components/policy/core/browser/BUILD.gn index 9e19d6e..6de6120 100644 --- a/components/policy/core/browser/BUILD.gn +++ b/components/policy/core/browser/BUILD.gn @@ -20,13 +20,13 @@ source_set("browser") { "//base", "//base:prefs", "//base/third_party/dynamic_annotations", + "//components/bookmarks/browser", "//components/keyed_service/core", "//components/pref_registry", "//components/strings", "//components/url_matcher", "//net", "//ui/base", - #'bookmarks_browser', TODO(GYP) ] if (enable_configuration_policy) { diff --git a/components/search_engines/BUILD.gn b/components/search_engines/BUILD.gn index e8cd405..ce921e4 100644 --- a/components/search_engines/BUILD.gn +++ b/components/search_engines/BUILD.gn @@ -44,6 +44,7 @@ static_library("search_engines") { deps = [ ":prepopulated_engines", "//base", + "//components/google/core/browser", "//components/keyed_service/core", "//components/metrics/proto", "//components/pref_registry", @@ -58,7 +59,6 @@ static_library("search_engines") { "//third_party/libxml", "//ui/gfx", "//url", - #'google_core_browser', TODO(GYP) ] if (enable_configuration_policy) { |