summaryrefslogtreecommitdiffstats
path: root/components
diff options
context:
space:
mode:
authorisherman@chromium.org <isherman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-12-12 14:15:18 +0000
committerisherman@chromium.org <isherman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-12-12 14:15:18 +0000
commit29a80d8fad910269d09c0886f4132d9e6c3e8514 (patch)
treec57307ca12a25499919de98db2b39293caee9187 /components
parentca637782be5b55b07d2368c31ebb7077ea4f34cf (diff)
downloadchromium_src-29a80d8fad910269d09c0886f4132d9e6c3e8514.zip
chromium_src-29a80d8fad910269d09c0886f4132d9e6c3e8514.tar.gz
chromium_src-29a80d8fad910269d09c0886f4132d9e6c3e8514.tar.bz2
[Autofill] Ignore password fields in quality metrics.
Password fields aren't ever filled by the Autofill feature, so this just adds confusion to the metrics. BUG=none TEST=none R=gcasto@chromium.org Review URL: https://codereview.chromium.org/112203002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240318 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'components')
-rw-r--r--components/autofill/core/browser/form_structure.cc6
1 files changed, 6 insertions, 0 deletions
diff --git a/components/autofill/core/browser/form_structure.cc b/components/autofill/core/browser/form_structure.cc
index 37e0bc9..007bc50 100644
--- a/components/autofill/core/browser/form_structure.cc
+++ b/components/autofill/core/browser/form_structure.cc
@@ -768,6 +768,12 @@ void FormStructure::LogQualityMetrics(
if (field_types.count(EMPTY_TYPE) || field_types.count(UNKNOWN_TYPE))
continue;
+ // Similarly, no further logging for password fields. Those are primarily
+ // related to a different feature code path, and so make more sense to track
+ // outside of this metric.
+ if (field->form_control_type == "password")
+ continue;
+
++num_detected_field_types;
if (field->is_autofilled)
did_autofill_some_possible_fields = true;