diff options
author | xunlu <xunlu@chromium.org> | 2015-07-09 11:55:43 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-07-09 18:56:25 +0000 |
commit | 6cfdae92467fe89ffa4ac5d5d65046757ac516b9 (patch) | |
tree | ac537c41d035f8ad2c87dc13fe844b4e22d075e0 /components | |
parent | b6a13344d187e9b78b53f6fa87b3f0550b31df8b (diff) | |
download | chromium_src-6cfdae92467fe89ffa4ac5d5d65046757ac516b9.zip chromium_src-6cfdae92467fe89ffa4ac5d5d65046757ac516b9.tar.gz chromium_src-6cfdae92467fe89ffa4ac5d5d65046757ac516b9.tar.bz2 |
[Password Manager] Add UMA statistics for PasswordForm::ssl_valid usage
We are planning to drop the PasswordForm::ssl_valid field as it's no longer used in new password forms and we believe it was set very rarely. This change will give us the statistics to confirm our belief.
BUG=413020
Review URL: https://codereview.chromium.org/1217273007
Cr-Commit-Position: refs/heads/master@{#338103}
Diffstat (limited to 'components')
-rw-r--r-- | components/password_manager/core/browser/login_database.cc | 17 |
1 files changed, 17 insertions, 0 deletions
diff --git a/components/password_manager/core/browser/login_database.cc b/components/password_manager/core/browser/login_database.cc index d4609ce..52b726d 100644 --- a/components/password_manager/core/browser/login_database.cc +++ b/components/password_manager/core/browser/login_database.cc @@ -24,6 +24,7 @@ #include "sql/connection.h" #include "sql/statement.h" #include "sql/transaction.h" +#include "url/url_constants.h" using autofill::PasswordForm; @@ -527,6 +528,22 @@ void LoginDatabase::ReportMetrics(const std::string& sync_username, "PasswordManager.EmptyUsernames.WithoutCorrespondingNonempty", num_entries); } + + sql::Statement invalid_ssl_cert_statement(db_.GetCachedStatement( + SQL_FROM_HERE, "SELECT origin_url, ssl_valid FROM logins;")); + + if (!invalid_ssl_cert_statement.is_valid()) + return; + + while (invalid_ssl_cert_statement.Step()) { + GURL url = GURL(invalid_ssl_cert_statement.ColumnString(0)); + + if (url.SchemeIs(url::kHttpsScheme)) { + metrics_util::LogUMAHistogramBoolean( + "PasswordManager.UserStoredPasswordWithInvalidSSLCert", + invalid_ssl_cert_statement.ColumnInt(1) == 0); + } + } } PasswordStoreChangeList LoginDatabase::AddLogin(const PasswordForm& form) { |