diff options
author | dewittj@chromium.org <dewittj@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-05-08 00:43:11 +0000 |
---|---|---|
committer | dewittj@chromium.org <dewittj@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-05-08 00:43:11 +0000 |
commit | 11d7f960684686a2cd7f3422c8133c97672cb818 (patch) | |
tree | 104866ed154563403c740a15d8e65f51d0138bba /content/app | |
parent | 0a999393b6ff0b45e70ad14e3c3e637da5ec8119 (diff) | |
download | chromium_src-11d7f960684686a2cd7f3422c8133c97672cb818.zip chromium_src-11d7f960684686a2cd7f3422c8133c97672cb818.tar.gz chromium_src-11d7f960684686a2cd7f3422c8133c97672cb818.tar.bz2 |
Revert 198834 "Add chrome_split_dll gyp variable, and duplicate ..."
> Add chrome_split_dll gyp variable, and duplicate chrome_main_dll target
>
> Currently contains chrome_browser_dll target. Removes some paths from browser->webcore
> via content that are there due to single process mode, and removes dependency of content
> on content_renderer.
>
> Current remaining paths from chrome_browser_dll to webcore: http://i.imgur.com/7WWRvpA.jpg
>
> R=cpu@chromium.org
> BUG=237249
>
> Review URL: https://chromiumcodereview.appspot.com/14682014
TBR=scottmg@chromium.org
Review URL: https://codereview.chromium.org/14882004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198837 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/app')
-rw-r--r-- | content/app/content_main_runner.cc | 22 |
1 files changed, 2 insertions, 20 deletions
diff --git a/content/app/content_main_runner.cc b/content/app/content_main_runner.cc index ed490eb..9f1947a 100644 --- a/content/app/content_main_runner.cc +++ b/content/app/content_main_runner.cc @@ -165,8 +165,7 @@ namespace content { base::LazyInstance<ContentBrowserClient> g_empty_content_browser_client = LAZY_INSTANCE_INITIALIZER; -// TODO(scottmg): http://crbug.com/237249 Split into browser and child. -#if !defined(OS_IOS) && !defined(CHROME_SPLIT_DLL) +#if !defined(OS_IOS) base::LazyInstance<ContentPluginClient> g_empty_content_plugin_client = LAZY_INSTANCE_INITIALIZER; base::LazyInstance<ContentRendererClient> @@ -298,13 +297,8 @@ class ContentClientInitializer { process_type == switches::kPpapiPluginProcess) { if (delegate) content_client->plugin_ = delegate->CreateContentPluginClient(); - // TODO(scottmg): http://crbug.com/237249 Should be in _child. -#if !defined(CHROME_SPLIT_DLL) if (!content_client->plugin_) content_client->plugin_ = &g_empty_content_plugin_client.Get(); -#endif - // Single process not supported in split dll mode. -#if !defined(CHROME_SPLIT_DLL) } else if (process_type == switches::kRendererProcess || CommandLine::ForCurrentProcess()->HasSwitch( switches::kSingleProcess)) { @@ -312,15 +306,11 @@ class ContentClientInitializer { content_client->renderer_ = delegate->CreateContentRendererClient(); if (!content_client->renderer_) content_client->renderer_ = &g_empty_content_renderer_client.Get(); -#endif } else if (process_type == switches::kUtilityProcess) { if (delegate) content_client->utility_ = delegate->CreateContentUtilityClient(); - // TODO(scottmg): http://crbug.com/237249 Should be in _child. -#if !defined(CHROME_SPLIT_DLL) if (!content_client->utility_) content_client->utility_ = &g_empty_content_utility_client.Get(); -#endif } #endif // !OS_IOS } @@ -411,22 +401,14 @@ int RunNamedProcessTypeMain( ContentMainDelegate* delegate) { static const MainFunction kMainFunctions[] = { { "", BrowserMain }, + { switches::kRendererProcess, RendererMain }, #if defined(ENABLE_PLUGINS) - // TODO(scottmg): http://crbug.com/237249 This will have to be split into - // content_main_runner_browser and content_main_runner_child. -#if !defined(CHROME_SPLIT_DLL) { switches::kPluginProcess, PluginMain }, { switches::kWorkerProcess, WorkerMain }, -#endif { switches::kPpapiPluginProcess, PpapiPluginMain }, { switches::kPpapiBrokerProcess, PpapiBrokerMain }, #endif - // TODO(scottmg): http://crbug.com/237249 This will have to be split into - // content_main_runner_browser and content_main_runner_child. -#if !defined(CHROME_SPLIT_DLL) { switches::kUtilityProcess, UtilityMain }, - { switches::kRendererProcess, RendererMain }, -#endif { switches::kGpuProcess, GpuMain }, }; |