diff options
author | dmazzoni <dmazzoni@chromium.org> | 2014-10-07 14:15:08 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-10-07 21:15:29 +0000 |
commit | 3531e1110c2c057b89a192b2ca05d95ca98f4aec (patch) | |
tree | bc2febbbf10219639cf72885491a29e1a67860c7 /content/browser/accessibility/browser_accessibility_manager_android.cc | |
parent | b3e7acfa2273ba3c88b988db4e85beb1014ea35f (diff) | |
download | chromium_src-3531e1110c2c057b89a192b2ca05d95ca98f4aec.zip chromium_src-3531e1110c2c057b89a192b2ca05d95ca98f4aec.tar.gz chromium_src-3531e1110c2c057b89a192b2ca05d95ca98f4aec.tar.bz2 |
Initialize initial AX tree after BrowserAccessibilityManagerWin.
This was a subtle bug - the initial AX tree was being initialized
in the BrowserAccessibilityManager constructor, before the subclass,
BrowserAccessibilityManagerWin, was constructed. That meant that
BrowserAccessibilityManagerWin overrides were not being called,
so the native Win objects for the initial tree were not working.
In particular, BrowserAccessibilityManagerWin::OnNodeCreated
wasn't getting called, so the mapping from Windows unique ids
to objects wasn't getting initialized.
The user impact of this is that when loading a new URL, NVDA would
sometimes announce "Unknown" - this is because it'd get events on
the initial document (before the real page loads), but attempts to
query that initial document would fail.
Adds a unit test to demonstrate exactly what failed and prevent it
from regressing.
BUG=421116
Review URL: https://codereview.chromium.org/631223005
Cr-Commit-Position: refs/heads/master@{#298573}
Diffstat (limited to 'content/browser/accessibility/browser_accessibility_manager_android.cc')
-rw-r--r-- | content/browser/accessibility/browser_accessibility_manager_android.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/content/browser/accessibility/browser_accessibility_manager_android.cc b/content/browser/accessibility/browser_accessibility_manager_android.cc index e878e6c..678bd69 100644 --- a/content/browser/accessibility/browser_accessibility_manager_android.cc +++ b/content/browser/accessibility/browser_accessibility_manager_android.cc @@ -74,8 +74,9 @@ BrowserAccessibilityManagerAndroid::BrowserAccessibilityManagerAndroid( const ui::AXTreeUpdate& initial_tree, BrowserAccessibilityDelegate* delegate, BrowserAccessibilityFactory* factory) - : BrowserAccessibilityManager(initial_tree, delegate, factory) { + : BrowserAccessibilityManager(delegate, factory) { SetContentViewCore(content_view_core); + Initialize(initial_tree); } BrowserAccessibilityManagerAndroid::~BrowserAccessibilityManagerAndroid() { |