diff options
| author | mkwst@chromium.org <mkwst@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-18 12:30:45 +0000 |
|---|---|---|
| committer | mkwst@chromium.org <mkwst@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-18 12:30:45 +0000 |
| commit | 39d842cd75fbdbaf30e93cd9beff983cd3acb348 (patch) | |
| tree | c78c63822d24adc90384b98b7cbe0c2e0d18a0ed /content/browser/accessibility/browser_accessibility_state_impl.h | |
| parent | f98bb7f5ef1e6ce518b021826256beb9ac58335e (diff) | |
| download | chromium_src-39d842cd75fbdbaf30e93cd9beff983cd3acb348.zip chromium_src-39d842cd75fbdbaf30e93cd9beff983cd3acb348.tar.gz chromium_src-39d842cd75fbdbaf30e93cd9beff983cd3acb348.tar.bz2 | |
Revert of Revert of Migrate accessibility from RenderView to RenderFrame. (https://codereview.chromium.org/407493002/)
Reason for revert:
Reverting the revert. This didn't break the tree; it's still broken without the patch. :(
Sorry for the noise!
Original issue's description:
> Revert of Migrate accessibility from RenderView to RenderFrame. (https://codereview.chromium.org/273423004/)
>
> Reason for revert:
> Speculative revert to fix XP bots.
>
> XP bots started crashing http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/32011 and http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%282%29/builds/34677
>
> This CL is the most suspicious in the range. If it doesn't fix the bots, I'll unrevert it.
>
> Original issue's description:
> > Migrate accessibility from RenderView to RenderFrame and RVH to RFH.
> >
> > In preparation for out-of-process iframes, move almost all accessibility
> > functionality from RenderView to RenderFrame, and from RVHI and RWHI
> > to RFHI.
> >
> > In addition, the accessibility mode is moved to WebContents, and changing
> > the mode triggers changing it on all frames.
> >
> > BUG=368298
> > R=jam@chromium.org, kenrb@chromium.org, nick@chromium.org
> >
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283994
>
> TBR=dmazzoni@chromium.org
> NOTRY=true
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284032
TBR=creis@chromium.org,nick@chromium.org,nasko@chromium.org,jam@chromium.org,dtseng@chromium.org,jschuh@chromium.org,tsepez@chromium.org,kenrb@chromium.org,dmazzoni@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/407493004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284065 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/browser/accessibility/browser_accessibility_state_impl.h')
| -rw-r--r-- | content/browser/accessibility/browser_accessibility_state_impl.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/content/browser/accessibility/browser_accessibility_state_impl.h b/content/browser/accessibility/browser_accessibility_state_impl.h index 2a1b1c6..6529d2d 100644 --- a/content/browser/accessibility/browser_accessibility_state_impl.h +++ b/content/browser/accessibility/browser_accessibility_state_impl.h @@ -10,7 +10,7 @@ #include "base/basictypes.h" #include "base/compiler_specific.h" #include "base/memory/singleton.h" -#include "content/common/view_message_enums.h" +#include "content/common/accessibility_mode_enums.h" #include "content/public/browser/browser_accessibility_state.h" namespace content { @@ -76,9 +76,9 @@ class CONTENT_EXPORT BrowserAccessibilityStateImpl void UpdatePlatformSpecificHistograms(); - // Updates the accessibility mode of all render widgets, including swapped out + // Updates the accessibility mode of all web contents, including swapped out // ones. |add| specifies whether the mode should be added or removed. - void AddOrRemoveFromRenderWidgets(AccessibilityMode mode, bool add); + void AddOrRemoveFromAllWebContents(AccessibilityMode mode, bool add); AccessibilityMode accessibility_mode_; |