diff options
| author | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-08-02 01:04:42 +0000 |
|---|---|---|
| committer | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-08-02 01:04:42 +0000 |
| commit | a515f3fbb078ae5d3d6fa89e58d2547fb808cb60 (patch) | |
| tree | a379b2ab776970a7435e3884d71ae640144c95ad /content/browser/accessibility/browser_accessibility_win.h | |
| parent | 221c45d997d7cd70cc4c1af5ff7614875d5b8844 (diff) | |
| download | chromium_src-a515f3fbb078ae5d3d6fa89e58d2547fb808cb60.zip chromium_src-a515f3fbb078ae5d3d6fa89e58d2547fb808cb60.tar.gz chromium_src-a515f3fbb078ae5d3d6fa89e58d2547fb808cb60.tar.bz2 | |
Revert 149510 - Allow filters in accessibility tests to specify which attributes to check.
This may have caused the Win 7 WebKit canary bot to begin crashing; see
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=accessibility%2Floading-iframe-updates-axtree.html
If rolling this out does not fix the bot, I will put it back in later tonight.
With this change, a DumpAccessibilityTree test can specify filters to
control which attributes are printed. This keeps each test expectation file
small and readable, while making it easy to test for all sorts of attributes,
including obscure ones.
Each platform will have a few attributes that print by default, like the
role and name. HTML files add rules of this form to override the defaults:
@MAC-DENY:subrole*
@MAC-DENY:value*
@MAC-ALLOW:description*
You can also specify @MAC-ALLOW:* or @WIN-ALLOW:* if you want to dump everything - helpful
during development sometimes.
BUG=124314
Review URL: https://chromiumcodereview.appspot.com/10662003
TBR=dmazzoni@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10837065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149550 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/browser/accessibility/browser_accessibility_win.h')
| -rw-r--r-- | content/browser/accessibility/browser_accessibility_win.h | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/content/browser/accessibility/browser_accessibility_win.h b/content/browser/accessibility/browser_accessibility_win.h index c4385d0..03f70a7 100644 --- a/content/browser/accessibility/browser_accessibility_win.h +++ b/content/browser/accessibility/browser_accessibility_win.h @@ -747,14 +747,9 @@ BrowserAccessibilityWin REFIID iid, void** object); - // Accessors. - int32 ia_role() const { return ia_role_; } - int32 ia_state() const { return ia_state_; } - int32 ia2_role() const { return ia2_role_; } - int32 ia2_state() const { return ia2_state_; } - const std::vector<string16>& ia2_attributes() const { - return ia2_attributes_;\ - } + // Accessors to IA2 role and state. + int32 ia2_role() { return ia2_role_; } + int32 ia2_state() { return ia2_state_; } private: // Add one to the reference count and return the same object. Always |