diff options
| author | brettw <brettw@chromium.org> | 2015-07-14 15:42:19 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-07-14 22:43:54 +0000 |
| commit | 0eabfa001ba06d3c66992b95b69a988ef0633992 (patch) | |
| tree | a62a2b2c2e828f99ac192c41048e247fb0aa32da /content/browser/accessibility/dump_accessibility_browsertest_base.cc | |
| parent | 28c7c11feb94dc2593e5a4bf2b7aeb9d15bd0e49 (diff) | |
| download | chromium_src-0eabfa001ba06d3c66992b95b69a988ef0633992.zip chromium_src-0eabfa001ba06d3c66992b95b69a988ef0633992.tar.gz chromium_src-0eabfa001ba06d3c66992b95b69a988ef0633992.tar.bz2 | |
Move JoinString to the base namespace.
Change "Separator" from string to StringPIece (most are constants). Remove char versions for symmetry with SplitString.
Update callers who pass empty separators to use a base::StringPiece()
Change chromecast/base/metrics/cast_metrics_helper.cc to not use JoinString at all and just append to the output (code is simpler and faster).
TBR=zelidrag@chromium.org for chromeos
Review URL: https://codereview.chromium.org/1223153003
Cr-Commit-Position: refs/heads/master@{#338762}
Diffstat (limited to 'content/browser/accessibility/dump_accessibility_browsertest_base.cc')
| -rw-r--r-- | content/browser/accessibility/dump_accessibility_browsertest_base.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/content/browser/accessibility/dump_accessibility_browsertest_base.cc b/content/browser/accessibility/dump_accessibility_browsertest_base.cc index f6da92c..2a9a1ef 100644 --- a/content/browser/accessibility/dump_accessibility_browsertest_base.cc +++ b/content/browser/accessibility/dump_accessibility_browsertest_base.cc @@ -202,7 +202,7 @@ void DumpAccessibilityTestBase::RunTest( // file length differences are found. expected_lines.push_back(kMarkEndOfFile); actual_lines.push_back(kMarkEndOfFile); - std::string actual_contents = JoinString(actual_lines, "\n"); + std::string actual_contents = base::JoinString(actual_lines, "\n"); std::vector<int> diff_lines = DiffLines(expected_lines, actual_lines); bool is_different = diff_lines.size() > 0; |