diff options
| author | plundblad@chromium.org <plundblad@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-12 14:04:25 +0000 |
|---|---|---|
| committer | plundblad@chromium.org <plundblad@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-12 14:04:25 +0000 |
| commit | f70794dd6dfb6ad47362ac12a54575562653fe93 (patch) | |
| tree | 8146965521af818880624df214df10500d552a6a /content/browser/accessibility | |
| parent | ade1968e7cd5270ce9064125ce99be231a1c9775 (diff) | |
| download | chromium_src-f70794dd6dfb6ad47362ac12a54575562653fe93.zip chromium_src-f70794dd6dfb6ad47362ac12a54575562653fe93.tar.gz chromium_src-f70794dd6dfb6ad47362ac12a54575562653fe93.tar.bz2 | |
Fix android accessibility action handling to return true on success and to fail on stale nodes.
This fixes clicking on nodes in the accessibility node tree using
BrailleBack. Before, BrailleBack would emit its not by everyone
appreciated failure beep when clicking, leading the user to think
that the click didn't work. Now, we return true for successful actions
and also send the appropriate VIEW_CLICKED event for a click action.
Also, stop performing actions (such as setting focus) to nodes that aren't
in the tree.
BUG=none
R=dmazzoni@chomium.org
Review URL: https://codereview.chromium.org/110063004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240313 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/browser/accessibility')
| -rw-r--r-- | content/browser/accessibility/browser_accessibility_manager_android.cc | 5 | ||||
| -rw-r--r-- | content/browser/accessibility/browser_accessibility_manager_android.h | 1 |
2 files changed, 6 insertions, 0 deletions
diff --git a/content/browser/accessibility/browser_accessibility_manager_android.cc b/content/browser/accessibility/browser_accessibility_manager_android.cc index 63f461c..c16bc55 100644 --- a/content/browser/accessibility/browser_accessibility_manager_android.cc +++ b/content/browser/accessibility/browser_accessibility_manager_android.cc @@ -161,6 +161,11 @@ jint BrowserAccessibilityManagerAndroid::GetRootId(JNIEnv* env, jobject obj) { return static_cast<jint>(root_->renderer_id()); } +jboolean BrowserAccessibilityManagerAndroid::IsNodeValid( + JNIEnv* env, jobject obj, jint id) { + return GetFromRendererID(id) != NULL; +} + jint BrowserAccessibilityManagerAndroid::HitTest( JNIEnv* env, jobject obj, jint x, jint y) { BrowserAccessibilityAndroid* result = diff --git a/content/browser/accessibility/browser_accessibility_manager_android.h b/content/browser/accessibility/browser_accessibility_manager_android.h index 1b7bded..6a9f38d 100644 --- a/content/browser/accessibility/browser_accessibility_manager_android.h +++ b/content/browser/accessibility/browser_accessibility_manager_android.h @@ -42,6 +42,7 @@ class CONTENT_EXPORT BrowserAccessibilityManagerAndroid // Tree methods. jint GetRootId(JNIEnv* env, jobject obj); + jboolean IsNodeValid(JNIEnv* env, jobject obj, jint id); jint HitTest(JNIEnv* env, jobject obj, jint x, jint y); // Populate Java accessibility data structures with info about a node. |