summaryrefslogtreecommitdiffstats
path: root/content/browser/android
diff options
context:
space:
mode:
authorjdduke@chromium.org <jdduke@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-05-11 01:08:10 +0000
committerjdduke@chromium.org <jdduke@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-05-11 01:08:10 +0000
commit950a829a607e849b22b506499e84fbb7e95dd668 (patch)
tree2062e83e67b52bc1d19093aa69e6db84e3aed2f4 /content/browser/android
parent563594a497169e986ed7ba922a153faed9fafd0e (diff)
downloadchromium_src-950a829a607e849b22b506499e84fbb7e95dd668.zip
chromium_src-950a829a607e849b22b506499e84fbb7e95dd668.tar.gz
chromium_src-950a829a607e849b22b506499e84fbb7e95dd668.tar.bz2
Revert of Android-side of insertion/selection handles visibility. (https://codereview.chromium.org/188023002/)
Reason for revert: There are a number of cases where this incorrectly hides the selection/insertion handles in an editable node. Original issue's description: > Android-side of insertion/selection handles visibility. > > This patch relies on other two patches: > https://codereview.chromium.org/177903010/ > https://codereview.chromium.org/186753002/ > to correctly compute the visibility of selection and > insertion handles when editing text input, text area > and contenteditable elements. > > BUG=236033 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258839 BUG=372056 TBR=tedchoc@chromium.org Review URL: https://codereview.chromium.org/278923003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269667 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/browser/android')
-rw-r--r--content/browser/android/content_view_core_impl.cc14
-rw-r--r--content/browser/android/content_view_core_impl.h1
2 files changed, 0 insertions, 15 deletions
diff --git a/content/browser/android/content_view_core_impl.cc b/content/browser/android/content_view_core_impl.cc
index e0aa1d8..9f4ebfb 100644
--- a/content/browser/android/content_view_core_impl.cc
+++ b/content/browser/android/content_view_core_impl.cc
@@ -681,20 +681,6 @@ void ContentViewCoreImpl::OnSelectionBoundsChanged(
params.is_anchor_first);
}
-void ContentViewCoreImpl::OnSelectionRootBoundsChanged(
- const gfx::Rect& bounds) {
- JNIEnv* env = AttachCurrentThread();
-
- ScopedJavaLocalRef<jobject> obj = java_ref_.get(env);
- if (obj.is_null())
- return;
-
- ScopedJavaLocalRef<jobject> rect_object(CreateJavaRect(env, bounds));
- Java_ContentViewCore_setSelectionRootBounds(env,
- obj.obj(),
- rect_object.obj());
-}
-
void ContentViewCoreImpl::ShowPastePopup(int x_dip, int y_dip) {
JNIEnv* env = AttachCurrentThread();
ScopedJavaLocalRef<jobject> obj = java_ref_.get(env);
diff --git a/content/browser/android/content_view_core_impl.h b/content/browser/android/content_view_core_impl.h
index 4c52005..52cf643 100644
--- a/content/browser/android/content_view_core_impl.h
+++ b/content/browser/android/content_view_core_impl.h
@@ -265,7 +265,6 @@ class ContentViewCoreImpl : public ContentViewCore,
void OnSelectionChanged(const std::string& text);
void OnSelectionBoundsChanged(
const ViewHostMsg_SelectionBounds_Params& params);
- void OnSelectionRootBoundsChanged(const gfx::Rect& bounds);
void StartContentIntent(const GURL& content_url);