diff options
author | danakj@chromium.org <danakj@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-09-13 22:29:16 +0000 |
---|---|---|
committer | danakj@chromium.org <danakj@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-09-13 22:29:16 +0000 |
commit | fa282ad09855ade5832411e0ee5a7cc64dda2484 (patch) | |
tree | df28692447720ab4978efd99b05fcda8d59e17e1 /content/browser/aura/resize_lock.cc | |
parent | be70b395f0b474a01757f8dea88c2d1d3854c464 (diff) | |
download | chromium_src-fa282ad09855ade5832411e0ee5a7cc64dda2484.zip chromium_src-fa282ad09855ade5832411e0ee5a7cc64dda2484.tar.gz chromium_src-fa282ad09855ade5832411e0ee5a7cc64dda2484.tar.bz2 |
Revert 223140 "aura: When skipping frames, ensure next frame dam..."
compile errors that the trybots didn't catch??
> aura: When skipping frames, ensure next frame damages what was skipped.
>
> In the delegated path, if we skip a frame, we are just dropping the
> damage. If the resize lock times out, we can end up swapping a partial
> frame that is out of sync with the rest of the visible content.
>
> Since we always have all the quads available to us (unlike the old
> double-buffered texture path), when we stop skipping a frame, just
> damage the whole RenderWidgetHostView to ensure we draw the skipped
> frames' damage.
>
> Refactors ResizeLock out so that we can fake it out in tests.
>
> Tests:
> RenderWidgetHostViewAuraTest.SkippedDelegatedFrames
>
> R=jbauman, piman
> BUG=288993
> Depends on: https://codereview.chromium.org/23506032/
>
> Review URL: https://chromiumcodereview.appspot.com/23496042
TBR=danakj@chromium.org
Review URL: https://codereview.chromium.org/23455052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223142 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/browser/aura/resize_lock.cc')
-rw-r--r-- | content/browser/aura/resize_lock.cc | 35 |
1 files changed, 0 insertions, 35 deletions
diff --git a/content/browser/aura/resize_lock.cc b/content/browser/aura/resize_lock.cc deleted file mode 100644 index 4c8cd95..0000000 --- a/content/browser/aura/resize_lock.cc +++ /dev/null @@ -1,35 +0,0 @@ -// Copyright 2013 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#include "content/browser/aura/resize_lock.h" - -namespace content { - -ResizeLock::ResizeLock(const gfx::Size new_size, bool defer_compositor_lock) - : new_size_(new_size), - defer_compositor_lock_(defer_compositor_lock) { - if (!defer_compositor_lock_) - LockCompositor(); -} - -ResizeLock::~ResizeLock() { - UnlockCompositor(); -} - -bool ResizeLock::GrabDeferredLock() { - if (!defer_compositor_lock_) - return false; - LockCompositor(); - return true; -} - -void ResizeLock::UnlockCompositor() { - defer_compositor_lock_ = false; -} - -void ResizeLock::LockCompositor() { - defer_compositor_lock_ = false; -} - -} // namespace content |