diff options
| author | rvargas@google.com <rvargas@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-08-12 19:27:52 +0000 |
|---|---|---|
| committer | rvargas@google.com <rvargas@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-08-12 19:27:52 +0000 |
| commit | c8b8b502f5d4b5ace8af3836f0734d269ff7383b (patch) | |
| tree | 928cbd493a2cd209f44048b1e1e6bea9c292a767 /content/browser/browser_main_runner.cc | |
| parent | b9f8f90ef27d2e725dd649dfc1f2cddaef04f4eb (diff) | |
| download | chromium_src-c8b8b502f5d4b5ace8af3836f0734d269ff7383b.zip chromium_src-c8b8b502f5d4b5ace8af3836f0734d269ff7383b.tar.gz chromium_src-c8b8b502f5d4b5ace8af3836f0734d269ff7383b.tar.bz2 | |
Revert 217049 "Make sure unexpected exit paths generate crash du..."
(this will be merged on a dedicated canary)
> Make sure unexpected exit paths generate crash dumps for the browser.
>
> Right now it is possible for some random code to directly terminate the
> browser process without generating a crash dump. This CL should fix that.
>
> BUG=none
> TEST=none
> R=jam@chromium.org
>
> Review URL: https://codereview.chromium.org/22264015
TBR=rvargas@chromium.org
Review URL: https://codereview.chromium.org/22877003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217053 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/browser/browser_main_runner.cc')
| -rw-r--r-- | content/browser/browser_main_runner.cc | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/content/browser/browser_main_runner.cc b/content/browser/browser_main_runner.cc index 1a349a2..cca1466 100644 --- a/content/browser/browser_main_runner.cc +++ b/content/browser/browser_main_runner.cc @@ -19,7 +19,6 @@ #if defined(OS_WIN) #include "base/win/metro.h" -#include "base/win/win_util.h" #include "base/win/windows_version.h" #include "ui/base/win/scoped_ole_initializer.h" #endif @@ -104,13 +103,6 @@ class BrowserMainRunnerImpl : public BrowserMainRunner { if (result_code > 0) return result_code; -#if defined(OS_WIN) - // The process should crash when going through abnormal termination. - // Make sure this is done only when Shutdown() will be called. - base::win::SetShouldCrashOnProcessDetach(true); - base::win::SetAbortBehaviorForCrashReporting(); -#endif - // Return -1 to indicate no early termination. return -1; } @@ -138,10 +130,6 @@ class BrowserMainRunnerImpl : public BrowserMainRunner { notification_service_.reset(NULL); -#if defined(OS_WIN) - base::win::SetShouldCrashOnProcessDetach(false); -#endif - is_shutdown_ = true; } |