Rewrite std::string("") to std::string(), Linux edition.

This patch was generated by running the empty_string clang tool
across the Chromium Linux compilation database. Implicitly or
explicitly constructing std::string() with a "" argument is
inefficient as the caller needs to emit extra instructions to
pass an argument, and the constructor needlessly copies a byte
into internal storage. Rewriting these instances to simply call
the default constructor appears to save ~14-18 kilobytes on an
optimized release build.

BUG=none

Review URL: https://codereview.chromium.org/13145003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193020 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 5 insertions, 5 deletions

diff --git a/content/browser/database_browsertest.cc b/content/browser/database_browsertest.cc
index 48f7304..29030ad 100644
--- a/content/browser/database_browsertest.cc
+++ b/content/browser/database_browsertest.cc
@@ -102,7 +102,7 @@ IN_PROC_BROWSER_TEST_F(DatabaseTest, DeleteRecord) {
   CreateTable(shell());
   InsertRecord(shell(), "text");
   DeleteRecord(shell(), 0);
-  CompareRecords(shell(), "");
+  CompareRecords(shell(), std::string());
 
   InsertRecord(shell(), "0");
   InsertRecord(shell(), "1");
@@ -151,12 +151,12 @@ IN_PROC_BROWSER_TEST_F(DatabaseTest, DatabaseOperations) {
   for (int i = 0; i < 10; ++i)
     DeleteRecord(shell(), 0);
 
-  CompareRecords(shell(), "");
+  CompareRecords(shell(), std::string());
 
   RunScriptAndCheckResult(
       shell(), "deleteRecord(1)", "could not find row with index: 1");
 
-  CompareRecords(shell(), "");
+  CompareRecords(shell(), std::string());
 }
 
 // Create records in the database and verify they persist after reload.
@@ -186,7 +186,7 @@ IN_PROC_BROWSER_TEST_F(DatabaseTest, OffTheRecordCannotReadRegularDatabase) {
   ASSERT_FALSE(HasTable(otr));
 
   CreateTable(otr);
-  CompareRecords(otr, "");
+  CompareRecords(otr, std::string());
 }
 
 // Attempt to read a database created in an off the record browser from a
@@ -200,7 +200,7 @@ IN_PROC_BROWSER_TEST_F(DatabaseTest, RegularCannotReadOffTheRecordDatabase) {
   Navigate(shell());
   ASSERT_FALSE(HasTable(shell()));
   CreateTable(shell());
-  CompareRecords(shell(), "");
+  CompareRecords(shell(), std::string());
 }
 
 // Verify DB changes within first window are present in the second window.