diff options
| author | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-11-18 00:34:30 +0000 |
|---|---|---|
| committer | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-11-18 00:34:30 +0000 |
| commit | f3b1a084a01ab82caf998daefcb989c66ff16135 (patch) | |
| tree | 1072e46976c2fb7fa82d72c74bdc579d78f0ce01 /content/browser/debugger | |
| parent | 8f0633691cd10779408642e2ad5eaa9b0c190b0a (diff) | |
| download | chromium_src-f3b1a084a01ab82caf998daefcb989c66ff16135.zip chromium_src-f3b1a084a01ab82caf998daefcb989c66ff16135.tar.gz chromium_src-f3b1a084a01ab82caf998daefcb989c66ff16135.tar.bz2 | |
Define the public interface for content browser RenderProcessHost. This interface is implemented by the RenderProcessHostImpl class which lives in content\browser\renderer_host\render_process_host_impl.cc/.h. The RenderProcessHostImpl class is a consolidation of the RenderProcessHost and BrowserRenderProcessHost classes.
The RenderProcessHost public interface was created from the now deleted RenderProcessHost class defined in content\browser\renderer_host\render_process_host.h.
Additional methods have been added to the interface to ensure that it works correctly with the MockRenderProcessHost class used by unit tests. I had to implement a number of overrides in the MockRenderProcessHost class to ensure that tests work correctly. This was because of assumptions in the tests that the MockRPH class was a real RPH which it was till now.
Added a TODO for the methods which could potentially be removed from this interface. Will revisit that in a subsequent CL.
BUG=98716
TEST=No change in functionality. Hopefully it all compiles and works.
Review URL: http://codereview.chromium.org/8515027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110615 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/browser/debugger')
| -rw-r--r-- | content/browser/debugger/render_view_devtools_agent_host.cc | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/content/browser/debugger/render_view_devtools_agent_host.cc b/content/browser/debugger/render_view_devtools_agent_host.cc index 99dc4d0..53467b2 100644 --- a/content/browser/debugger/render_view_devtools_agent_host.cc +++ b/content/browser/debugger/render_view_devtools_agent_host.cc @@ -8,7 +8,7 @@ #include "base/lazy_instance.h" #include "content/browser/debugger/devtools_manager.h" #include "content/browser/debugger/render_view_devtools_agent_host.h" -#include "content/browser/renderer_host/render_process_host.h" +#include "content/browser/renderer_host/render_process_host_impl.h" #include "content/browser/renderer_host/render_view_host.h" #include "content/browser/site_instance.h" #include "content/browser/tab_contents/tab_contents.h" @@ -64,12 +64,13 @@ void RenderViewDevToolsAgentHost::NotifyClientClosing() { content::NotificationService::current()->Notify( content::NOTIFICATION_DEVTOOLS_WINDOW_CLOSING, content::Source<content::BrowserContext>( - render_view_host_->site_instance()->GetProcess()->browser_context()), + render_view_host_->site_instance()->GetProcess()-> + GetBrowserContext()), content::Details<RenderViewHost>(render_view_host_)); } int RenderViewDevToolsAgentHost::GetRenderProcessId() { - return render_view_host_->process()->id(); + return render_view_host_->process()->GetID(); } RenderViewDevToolsAgentHost::~RenderViewDevToolsAgentHost() { |