diff options
author | kaznacheev@chromium.org <kaznacheev@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-03 16:29:06 +0000 |
---|---|---|
committer | kaznacheev@chromium.org <kaznacheev@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-03 16:29:06 +0000 |
commit | 852b34ba3a6d5186ea532c16163168d1d5e24b2e (patch) | |
tree | 2de58e3529aa1d789a32aa5276e211dcbaf87bac /content/browser/devtools/devtools_http_handler_unittest.cc | |
parent | 172d4decac6b97e4193cbe6ceca2a99e31e9e80e (diff) | |
download | chromium_src-852b34ba3a6d5186ea532c16163168d1d5e24b2e.zip chromium_src-852b34ba3a6d5186ea532c16163168d1d5e24b2e.tar.gz chromium_src-852b34ba3a6d5186ea532c16163168d1d5e24b2e.tar.bz2 |
DevTools: Extract target discovery and manipulation from DevToolsHttpHandlerImpl
Target discovery has moved into DevToolsHttpHandlerDelegate.
The new DevToolsTarget interface is introduced to encapsulate
access to target details (id, title, url etc) and manipulation
(activate, close, inspect).
It is now possible to have an implementation of DevToolsTarget
tied to a tab id instead of a RenderViewHost instance (which is the
prerequisite for fixing the referenced bug).
BUG=272174
Review URL: https://codereview.chromium.org/24995003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226771 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/browser/devtools/devtools_http_handler_unittest.cc')
-rw-r--r-- | content/browser/devtools/devtools_http_handler_unittest.cc | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/content/browser/devtools/devtools_http_handler_unittest.cc b/content/browser/devtools/devtools_http_handler_unittest.cc index a57c4cc..cc751f0 100644 --- a/content/browser/devtools/devtools_http_handler_unittest.cc +++ b/content/browser/devtools/devtools_http_handler_unittest.cc @@ -7,6 +7,7 @@ #include "content/browser/browser_thread_impl.h" #include "content/public/browser/devtools_http_handler.h" #include "content/public/browser/devtools_http_handler_delegate.h" +#include "content/public/browser/devtools_target.h" #include "net/socket/stream_listen_socket.h" #include "testing/gtest/include/gtest/gtest.h" @@ -64,12 +65,11 @@ class DummyDelegate : public DevToolsHttpHandlerDelegate { virtual std::string GetPageThumbnailData(const GURL& url) OVERRIDE { return std::string(); } - virtual RenderViewHost* CreateNewTarget() OVERRIDE { return NULL; } - virtual TargetType GetTargetType(RenderViewHost*) OVERRIDE { - return kTargetTypeTab; + virtual scoped_ptr<DevToolsTarget> CreateNewTarget() OVERRIDE { + return scoped_ptr<DevToolsTarget>(); } - virtual std::string GetViewDescription(content::RenderViewHost*) OVERRIDE { - return std::string(); + virtual void EnumerateTargets(TargetCallback callback) OVERRIDE { + callback.Run(TargetList()); } virtual scoped_ptr<net::StreamListenSocket> CreateSocketForTethering( net::StreamListenSocket::Delegate* delegate, |