summaryrefslogtreecommitdiffstats
path: root/content/browser/devtools/devtools_manager_unittest.cc
diff options
context:
space:
mode:
authorpfeldman@chromium.org <pfeldman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-08-08 10:09:02 +0000
committerpfeldman@chromium.org <pfeldman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-08-08 10:10:17 +0000
commitb3f957e631a55a3402c1520c51ff812dfe0dc74d (patch)
tree0ef6745898865c1e9fe7804681aca4ea3bfa5608 /content/browser/devtools/devtools_manager_unittest.cc
parent561aae85db69ae48593fbc298338da864c0d12e9 (diff)
downloadchromium_src-b3f957e631a55a3402c1520c51ff812dfe0dc74d.zip
chromium_src-b3f957e631a55a3402c1520c51ff812dfe0dc74d.tar.gz
chromium_src-b3f957e631a55a3402c1520c51ff812dfe0dc74d.tar.bz2
DevTools: migrate DevTools APIs to use WebContents instead of RenderViewHost.
R=dgozman@chromium.org, jam@chromium.org TBR=extensions) for simple RVH -> WebContents migration call sites., kalman (apps, mnaganov (android_webview) NOTRY=true Review URL: https://codereview.chromium.org/442303002 Cr-Commit-Position: refs/heads/master@{#288297} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288297 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/browser/devtools/devtools_manager_unittest.cc')
-rw-r--r--content/browser/devtools/devtools_manager_unittest.cc16
1 files changed, 8 insertions, 8 deletions
diff --git a/content/browser/devtools/devtools_manager_unittest.cc b/content/browser/devtools/devtools_manager_unittest.cc
index 75c5273..79b7654 100644
--- a/content/browser/devtools/devtools_manager_unittest.cc
+++ b/content/browser/devtools/devtools_manager_unittest.cc
@@ -101,7 +101,7 @@ TEST_F(DevToolsManagerTest, OpenAndManuallyCloseDevToolsClientHost) {
DevToolsManager* manager = DevToolsManager::GetInstance();
scoped_refptr<DevToolsAgentHost> agent(
- DevToolsAgentHost::GetOrCreateFor(rvh()));
+ DevToolsAgentHost::GetOrCreateFor(web_contents()));
EXPECT_FALSE(agent->IsAttached());
TestDevToolsClientHost client_host;
@@ -121,12 +121,12 @@ TEST_F(DevToolsManagerTest, ForwardMessageToClient) {
TestDevToolsClientHost client_host;
scoped_refptr<DevToolsAgentHost> agent_host(
- DevToolsAgentHost::GetOrCreateFor(rvh()));
+ DevToolsAgentHost::GetOrCreateFor(web_contents()));
manager->RegisterDevToolsClientHostFor(agent_host.get(), &client_host);
EXPECT_EQ(0, TestDevToolsClientHost::close_counter);
std::string m = "test message";
- agent_host = DevToolsAgentHost::GetOrCreateFor(rvh());
+ agent_host = DevToolsAgentHost::GetOrCreateFor(web_contents());
manager->DispatchOnInspectorFrontend(agent_host.get(), m);
EXPECT_TRUE(&m == client_host.last_sent_message);
@@ -142,8 +142,8 @@ TEST_F(DevToolsManagerTest, NoUnresponsiveDialogInInspectedContents) {
contents()->SetDelegate(&delegate);
TestDevToolsClientHost client_host;
- scoped_refptr<DevToolsAgentHost> agent_host(
- DevToolsAgentHost::GetOrCreateFor(inspected_rvh));
+ scoped_refptr<DevToolsAgentHost> agent_host(DevToolsAgentHost::GetOrCreateFor(
+ WebContents::FromRenderViewHost(inspected_rvh)));
DevToolsManager::GetInstance()->RegisterDevToolsClientHostFor(
agent_host.get(), &client_host);
@@ -183,7 +183,7 @@ TEST_F(DevToolsManagerTest, ReattachOnCancelPendingNavigation) {
TestDevToolsClientHost client_host;
DevToolsManager* devtools_manager = DevToolsManager::GetInstance();
devtools_manager->RegisterDevToolsClientHostFor(
- DevToolsAgentHost::GetOrCreateFor(rvh()).get(), &client_host);
+ DevToolsAgentHost::GetOrCreateFor(web_contents()).get(), &client_host);
// Navigate to new site which should get a new RenderViewHost.
const GURL url2("http://www.yahoo.com");
@@ -191,7 +191,7 @@ TEST_F(DevToolsManagerTest, ReattachOnCancelPendingNavigation) {
url2, Referrer(), PAGE_TRANSITION_TYPED, std::string());
EXPECT_TRUE(contents()->cross_navigation_pending());
EXPECT_EQ(devtools_manager->GetDevToolsAgentHostFor(&client_host),
- DevToolsAgentHost::GetOrCreateFor(pending_rvh()));
+ DevToolsAgentHost::GetOrCreateFor(web_contents()));
// Interrupt pending navigation and navigate back to the original site.
controller().LoadURL(
@@ -199,7 +199,7 @@ TEST_F(DevToolsManagerTest, ReattachOnCancelPendingNavigation) {
contents()->TestDidNavigate(rvh(), 1, url, PAGE_TRANSITION_TYPED);
EXPECT_FALSE(contents()->cross_navigation_pending());
EXPECT_EQ(devtools_manager->GetDevToolsAgentHostFor(&client_host),
- DevToolsAgentHost::GetOrCreateFor(rvh()));
+ DevToolsAgentHost::GetOrCreateFor(web_contents()));
client_host.Close(DevToolsManager::GetInstance());
}